EIPIP Meeting 109

Transcript

welcome to EIP meeting 109 this is issue number 356 on ecat herders GitHub repository on agenda we have open issues PRS and other topics to be discussed we have a bunch of open issues I believe they are spam we will just take a look at it and close if needed two call for inputs have been added and we can perhaps discuss other discussions from the previous meeting mostly related to R repositories then uh there is eips Insight I know we have been joined by one of the contributor of eips insight so we'll take a look at that and yeah that is all if anyone has anything else

to add please feel free to drop in so starting with the very first item uh that is discuss open issues PRS and other topics I'm just trying to understand here is like uh are we having a bug in the tool that we are using for EIP GitHub repository uh shared here PR 8493 as an example and uh it looks like uh the tag is suggesting that it is waiting for editor's review however I feel like editor has already shared their comment and it should be author's review so is it possible for anyone to maybe take a look and update us on that part I don't see Sam on the call I know

he is looking into to Ling mostly so yeah maybe we can skip this one and we'll get back when he is around or if anyone else has any comment please let us know very well moving on to the next item which is ERC PR 581 this is an update to a final proposal generally we do not encourage making any updates to a final proposal um but this update seems to have received review from contributors I guess um even from the existing editor uh existing author

so I wonder what editors want to do about it we merge this PR or just go with the policy do not merge anymore or maybe we can reframe the question does anyone has OB objection on merging PR 581 which is to update ERC 4626 and if there is no objection I would really appreciate if there is any comment left by editors suggesting it is good to go that would help you know kind of build consensus around it yes uh this has already been approved

by uh the list of author I see Senior Dogo uh he has already approved this proposal so yeah it can be merged okay thank you good gendering on it um Matt do you have any recommendation for this or you would be fine with it looks okay to me okay perfect so we can yeah we can add that in the decisions list that it could be good to go moving on to a bunch of issues um I would appreciate if someone can maybe take a look even after the call because

mostly looks like spam to me and if you feel so please feel free to close them I would like to discuss uh two issues here uh number one is a 650 on ERC again it does look like a Spam to me but U yeah please take a look uh does it need any real attention and the next one was uh 634 ERC 634 if any editor has any comment please feel free to

add moving on to the next section section call for input um on agenda we have two call for input added I think uh yeah deadline for the first one has already passed which was for issue 349 allowing append to security consideration in final proposal it seems like two of the three op editors are opposed to it are we good to close by suggesting that people are not in favor of it I know Sam is not on the call but we can perhaps leave the summary and we can

take care of it perfect yeah that's a very good suggestion we can close that one 349 and the other one is 357 um it seems only two editors have responded to it and both are in favor we do not see any response from Matt Matt do you have any thoughts on that any objection because today is the last date for that call for input as well sorry I'm just trying to pull it up I was deleting those spam issues uh it's a issue 357 I have shared

the link yeah Sam and kajander are in favor we have received response from them I mean I don't want to put you on the spot here I know today is the last day uh so yeah yeah please go ahead I'm sure yeah it looks fun to me okay perfect so it seems like all of them are in favor if you would want to just add a sentence over there as a comment that would be nice okay yeah I

think you already did perfect thank you and this can be closed as well um moving on to item number two which is other discussion and updates from the past meeting this is not an update but perhaps we have been discussing it in the past so I thought of bringing up to this meeting it is with respect to rip repo and I found this issue created on R repo issue number is 34 and where it suggests that the Depo is not getting uh autom merged of the proposals which are being proposed it's maybe because of the EIP bot is not enabled for the repo I wonder if uh this editors group may be able to help or

have any suggestion for RP ades and General I don't see any RP editors on the call um just wanted to bring it to attention uh in case any support can be provided by EAP and ERC Editor to this group that would be nice to have uh they are looking for some help with respect to enable bot in the gab repository moving on to the next item it is eips Insight where we try to report the status change with respect to each proposal and also try to track issues PRS collected every month as we can see on the table uh we

have 66 e related issues and PRS open and 90 with respect to ERC obviously RP has the lowest number I know we have been joined by um eips inside team member and I believe there was some discuss with respect to adding some features and toolings so may I invite a women to maybe give a demonstration of where we are at with respect to the tools yeah thank you Puja I'll share my screen and provide a demo for everyone perfect so we have added two tools one

is GitHub analytics and the review tracker in the GitHub Analytics we can visualize the monthly PR data from EIP eips and ercs repository so um for the month of September in 2024 you can see that there are 46 PRS that are created and U 17 Clos and 28 merge first let me show that data for validation purposes so uh there are 17 PR that are closed

and not much and you can see that there are 17 P that are closed and similarly for the merged ones there are 29 P that are closed and merg uh and you can see that the there are 28 here that is because uh our scheduler runs every 24 hours in order to check for updates and update so it will be uh uh updated later for every 24 hours and for the created PFS

there are 46 PS that are created in total and [Music] uh you can see that there are 46 P that are created and similarly open and uh review uh and review stands for number of P that are reviewed by editors in in this current month and you can also see all this data by selecting the month and year over here and then you can filter them out in order to check for them [Music] individually the graphs as well will be updated in order to have a good visualization of individually if

required and uh similar to PS you can also have the look at issues data so there are uh six open two closed and two created in the ises data for ercs you can see that there are six open in the uh six open issues in the ercs and then

uh uh and then one one issue that is closed and yeah six open two created and two closed is it and the created ones uh let me recheck on that and get back

with you with that there is there might be a small bug on that and there is another tool that is review review track and in that you can see the monthly number of P that are reviewed by uh each reviewer and in in the month of September 2024 there are five five reviews made by L light Clan five reviews by Sam Wilson and five RS by G and you can see the Fire reviews that

are made by uh light client over here and you can also validate that information using the query so uh you can see there are 8871 8856 8849 8845 8837 and you can see in the in this current month you can see the pr numbers until here these are the ones that are reviewed in this month and you can uh have a look at that data over here and also download it similarly you can also visualize the data for the erc's part

uh that's it for the update thank you for the update and I I wonder there were other request as well uh for Network upgrade page and addition of a status it means sure that so uh when you go to the individual eips that are involved in the network upgrade you can see that uh the there will be a network upgrade if if it is involved in any and also uh like you can watch the status timeline in order to have the look at number of days it took from changing

from one status to another every time so you can go to the IND like you can navigate yourself to individual eips and have a look at that Data Network upgrades and Status timeline for overview of the I that looks good to me questions from it looks good to me uh if anyone has any suggestion or question where and how they can reach you uh in if uh like you can reach out to us by creating an issue and also you

can share the feedback in this feedback form that we have attached in the footer and in case if you have found a bug you can report here uh and create an issue in our uh repository that sounds good thank you so much I I believe uh the request coming up from Sam Wilson about the addition of number of days and things like that has already been taken care of yeah yeah yes already taken care of perfect thank you so much and I hope people may take a look at this website um I see there are some inconsistencies we might want to take a look at why is it there and how

we can fix it but other than that it is looking great to me thank you for sharing yeah thank [Music] you I would encourage editors to uh take a look at it and uh suggest any feature that may be help helpful to keep track of issues and PRS o over the GitHub repositories of EIP ercs and RPS and we hope that this is um better represented and be able to communicate it to the community and with that I think we can perhaps take a look at this month's Insight if that's possible um do you

have that data for the month of September as well I'm sorry V if you are speaking you are on mute oh sorry yeah I have the data for September let me share my screen and so uh you can see the monthly insights in the inside inside section of uh for the month of September 2024 you can see that there are six PR that are uh six cips that are uh that have gotten into the uh draft

status and four for ERC stat uh I mean draft status for ercs and for the review status uh there are two eips that have promoted into the review status and six for the ercs and for the last call there is one for ERC and for final there is one in ERC and for stagnant there is one in eips you can also uh have a look at the data by clicking on that number uh you'll be redirected to this page where you can see all the VIPs that are in that status and once you click on them you can have a look at the uh status timeline of them in order to have

a better visualization and uh if you are confused in anything you can also uh read this uh text so that you can get a context of what is present in our website you can also visualize the data using individual graphs using uh by going to that page and you can see that there are six core and four ercs which matches with this one similarly for the final status there is one for realis like this yeah that's it for the

update perfect thank you so much I think this is helpful and we would be in a position to navigate uh through the tools that you have shared with us and collect the related information that's all about eips in website and I think there was one more request add eips Insight website link to the eips website I'm not sure if there is any PR with respect to that but if yes then please feel free to share on the Discord and we can discuss it yeah I will be raising that today okay perfect thank you next is EAP editing office server I have added the agenda for the next

editing office hour which is scheduled on uh October 1st at 1400 UTC any author if you are looking for attention for any PR that you have made either on EIP or ERC GitHub repository please feel free to add here on the agenda as a comment and we would love to include mostly we try to use this office hour to answer any question coming up from the new contributor side if you if you are trying to understand the process or process of standardization or process of documentation or may have questions with respect to your specific pull

request please join the meeting uh that is on October 1st at 1400 UTC I have also added the recording for the last office hour 44 meeting 44 for your reference and yeah the last item for today is uh r VI action item from earlier meetings I think there was one pending action item from my end uh which I'm sorry I could not finish that up which was with respect to uh updating a final EIP where Danny Ryan is the author um I know Danny is inactive right now but we

would like to get in touch and get that EI updated um yeah I think uh yeah I think that is all from the last meeting I don't see any other pending action open anyone has anything to add any questions uh quick update from my part I'm back to working on um like fixing the build and everything for eips and erc's so it's more uniform um I'll hopefully have more for the next call thank you for update Sam and um I

don't know uh if you're aware of this or not but uh just because you have joined us here again uh today um so I would like to share this with you there is an open issue at R GitHub repository which is which is with respect to EIP bot not enabled I wonder if there is anything that can be done for that repository please feel free to either respond there or suggest it to the editors I know you look into lot of tooling parts so just wanted to share with you thanks okay perfect and yeah there is one more thing which may require your attention that was the very first item here on the agenda with respect to uh the tags that we are adding to all PR author review

and editors review it seems like um the tag either is not working properly or or I am missing something I have added an example PR 8493 it seems that you have already shared your comment and it should be author's review not editor review anymore so yeah if you could maybe also take a look at it uh I think it's just because of a limitation in the way the the bot works it it just tags it as e-review um as long as no one has approved the pull request it do it doesn't actually bounce back and forth like yeah okay that clarifies thank you very well I think uh that's it for today anyone has has anything to add

share or maybe suggest something for the next meeting by the way talking about the next meeting when do we want to keep our next meeting do we want to get back to two weeks kadence or do we want to keep the third Wednesday of the month considering we're not crushed for time I think this is a good Cadence um the current once in once in a month or yeah I mean if we're wrapping up at 10:30 like we didn't use the full hour so I think we're we're okay for once a month okay perfect in that case if we want to keep it once in a month

and we consider third Wednesday of the month the next meeting would be scheduled for October 16th at 1400 UTC I will create the agenda so people can um add their issues or discussion Point respectively awesome yeah thank you everyone for joining us here today can I have a small uh update on my side regarding the inconsistency that we saw previously yes please go ahead yeah uh so uh for the erc's issues uh our website uh our website eips inser is

showing six uh six issues in our website in this in this uh only four are currently in the erc's repository and two of them are currently deleted so that's the reason like since our website need to update for every 24 hours uh that is not updated yet other than that uh like it is working well but this one is because the issues have been deleted these two that's the reason for inconsistency but the data is CCT thank you for sharing it would be nice if you could maybe add the time when you think that the scheduler will

update it so if there is any change uh before that time people may understand like okay I'm seeing this in inconsistency because it will update once and 24 hours okay yeah we'll do that perfect thank you anyone else has any question comment suggestion perfect thank you everyone for joining us today see you all on October 16th at 1400 UTC have a great rest of the day everyone