EIP Editing Office Hour #6
EIP Editing Office Hours · 15 Nov 2022 · 49:38
Meeting 6 of the EIP Editing Office Hour, held on 15 November 2022. EIP editors and proposal authors work through open pull requests and questions about the Ethereum standards process. This meeting covers a review of EIPs in Draft, Review, Last Call and Final status.
Topics
From EIP Editing Office Hours, hosted by ECH Institute.
Transcript
welcome to EAP editing office hour meeting six we are joined by a handful of EAP authors today I have shared a list of proposals for consideration for today's meeting and yeah over to you Sam and I can maybe point out the pull request number for which we have authors present on the call sure sure sounds good um so what do we want to start today and the first one is five seven seven three and that is in the draft status number is yeah the same okay see if my
screen share will work today it will not I will be right back okay let's try sharing my screen again you'll be officer all right yeah it's working perfect no nobody's five seven seven three uh you can find it in drop section all right okay so looks like we have some resolved
comments here let's take a look foreign I mean the limitation is still for the
foreign all right something like that maybe I just I I
think you're sharing the left side um resources is a very very general word like it can mean like like a consumable resource like gas it can mean like a link um so includes completely multimedia would probably help especially if it's for uh like kgs refugees and that's my suggestion I mean this one is probably not a hard suggestion um foreign okay so let's see um okay that's that's all right
um I think it's definitely better than it was for the description um if you can I try to Define what our resource is in here um but again it's hard to pack information into a short space so just do your best on that um [Music] yes I think this one is good yeah that's great perfect um yeah okay
across metaverse compatibility yeah that's it's reasonable okay um and that was down here perfect yeah I would never have guessed that's what
serve was the evolution no no no no any particular reason you're using um the quadruple backticks instead of triple um it's just when I'm writing dogs I
sometimes use three uh when writing within the code blocks so okay I'm not sure if so I'm not sure if our markdown writer does the four um so if it doesn't render right just just switch it to three um I don't really care otherwise yeah good good okay so that's taken care of um okay let's use
it's okay cool so all right yeah that's perfect sorry I have to stop my body from eating
something outer and back foreign box um okay whatever the solution isn't to find the specifications get research metadata so this metadata here that's the output
from the getman error resource metadata right okay something yeah so we'll just make that nice and
obvious um and then we can get rid of this one um okay so what are you gonna do with the uh get our resources function did you just remove it or yeah we did um rationale you explain why okay then go down to your rationale section okay
yes that's perfect that looks good and then so that looks like it's just been removed Okay so questions okay
okay yes I think you can probably keep the test cases um yeah I should be fine then yeah we saw this in other VIPs yeah I think so it should be okay [Music] so the only other thing I generally about like I should mention um some of the other editors feel strongly about including only cc0 licensed code um is there any chance you'd be willing to re-licens this as cc0 we all have to check I'm not really aware of what that lies in this okay
yeah especially leave a little note here and um you don't you don't have to but if you can we definitely prefer it yeah perfect okay okay cool and all right
so I think we are done with this one um yeah thanks for for um making those changes I really appreciate it and uh should be too much longer before it gets merged it was it was really good stuff Sam thanks a lot yeah thank you all right the next one is a pr5881 it is ready to be moved into final status okay okay so what are the changes we've got
going on here is it's just white space changes let's do come on GitHub let's go there we go so let's see if there are any discussions still going on on here yeah I mean it doesn't seem like there's
any active discussion threads some okay with the score in the final sorry else on here yeah if you guys have any questions foreign where are we going next the next one is five seven six eight and that is for the last call I believe okay yeah we have uh fixed all the uh Tech
issue okay yeah we're pretty based everything perfect yeah so this is going to last call okay just waiting for merge yeah yeah so this will need to be updated um so what's two weeks from today the 29th okay good foreign
[Music] foreign foreign
over here okay and then if we take off for this we have foreign we have privilege assigned is still here and then we're removing privilege assigned down here still
oh no okay it's just changed that makes sense okay okay good okay yeah same here just get rid of that one too and otherwise yeah it should be should be good um
feel free to just like take me on Discord or Twitter Twitter telegram or anywhere except GitHub uh when you're done and I'll just come back and take another look at it okay thank you no problem and the next one here is a Victor mentioned about a specific number you can find it in miscellaneous uh that is 5388 and the question here is how to categorize this EIP hero how is it a good question um yeah um
so it's definitely not networking um because yeah that's exclusively for the appear to be earlier um if you think we can have this one on tomorrow's call we can move it there so like whatever yep okay yeah
I think this is probably fine as ERC um I mean you could technically maybe put it into interface since it isn't a like stated for a single application it's standard for multiple applications but yeah I mean years he's fine for this okay okay has dropped maybe you can follow the recording and I think we have uh covered all the proposals for which we have the orbit to join back
sorry so Victor we were discussing uh 5388 and it looks like the suggestion is to have it in ERC do you have any thoughts to add or share okay yeah I don't have it I just want to kind of get the general concept I kind of apply that into Network oh sorry uh into interface ERC for yeah it's all blurry between interface CRC sometimes I don't really care too much for short videos and I see got it yeah no problem I just want to kind of run that by you yeah that works as in the asking for
sure awesome so the next one we have is five seven seven eight which is ready for moving into review status PR number is five seven eight seven eight yeah yeah I was requested for viewers all right let's see what this is this is going into review um foreign
foreign where are we going next uh it's five seven seven eight so here it is another author from EAB 5570 Sean do you have any specific pull request number if you can maybe share the link here uh it's it's not a specific pull request it's uh currently merged so it's in its draft I just had some questions oh yeah go for it um I'm just trying to figure out what the process is to get um for review and then obviously next stages as well and what sort of um will that process looks like really sure so it's entirely up to you to move
it into whatever state you want to move it into the editors won't ever touch your EOP without you making your PR at the except for like formatting stuff but generally speaking we don't touch it so uh when you think the EAP is in the state where it's ready for like wire audience review you just make a PR that changes the status into review and then it's your responsibility to kind of go out and get feedback from interested parties so for something like uh digital receipt non-fungible tokens you might want to talk to wallet developers to display these receipts you might want to talk to um vendors who would be generating these receipts and get them to give feedback on your proposal yeah definitely um so what sort of because I guess right now that's what I've been focusing on is getting Community sort of Engagement
with it because it's been quite a little bit quiet yeah um so and and I guess that's on me just know they're like sort of Engagement for it so would that be roadblocking to move it to review or oh no no review is is just what you're done making like significant changes to it and then you you just move it to review yeah okay awesome because I do have a couple items I want to review on it but like I guess I'm probably close to moving that there and then I think I'll probably go see if I can find some more people to comment on it sounds good yeah okay amazing thank you no problem and just one another piece of um suggestion here Sean maybe you can uh DM me uh later on to have you signed up
for p penny that is generally to provide an overview of The Proposal that helps get someone of the engagement on proposal implementation and awareness and so what was that called again um I missed um so there is this YouTube if you don't get her to share a YouTube talk on proposals that is called p and E uh maybe if you can DM me on ethereum Caterers Discord or mention it over there I'll provide you more details too yeah for that uh that's that's amazing thank you so much I'll do that all right uh so I think we are done with final last call review okay there is one other thing that I
wanted to check with you uh Sam we have received recently a lot of changes to proposals which are already existing in the final status those are listed under the miscellaneous category if you would maybe like to take a look the first one is 5903 pull request number 5903 all right these are always unpleasant right um this month we have received more than usual generally we get one or two but it's more than that okay and who's approved this we have
Panda pep foreign [Music] I think the actual Like official approach for this should be to remove the links um and not update them I don't want to have a precedent of updating uh sale and cips um moment s
foreign already um um
all right you want me to add do you want me to add 5887 to APAP next yeah yeah okay I can do that most of these things are going to be added to it just because not a problem I I try to like have a list created over here so you can go through and um you can do it later on if you would like and we can probably look into some of the new proposals which are there once you're done with this here us
okay I think that's pretty reasonable unless the um what's the actual death now look like King Synergy base execution
let's see okay okay so destination has been removed so 19 0. it's a 19-0 is foreign should be followed by the intended validator address and data designed so if we look at this it says 90s are the intended validator address
and then the name of your sign okay now I guess they haven't pushed the solid version of it okay um foreign
it's going on it's actually here so this is another final change okay let's see the rich death because
this is okay so we went all the way down to there okay so you're having those lines obviously they actually make you to do like real code and then so this is 114 500 and this is zero fourteen five hundreds what does that mean so this one is a okay back over here
okay I think it was this one um foreign okay
now this is way too much of a change for finally IP very nervous about these things and yeah like maybe you can uh yeah take a look later on as well I just wanted to highlight that we have received quite a few years yeah okay okay so see this is a comment all right what are we off to next okay I see a comment here to speak for it asterisk and slasher then formula do not appear okay fair enough now we have a bunch of draft proposals maybe we can start looking into it the
first one is five seven four eight sure all right make sure this exists and foreign they seem to be proposed in interface
category I hope that is fine oh yeah [Music] okay yes I think a lot of the comments that I left haven't been updated on this one so I'm just gonna move on and somebody else can yeah and the next one is five seven five three five seven five three hey another extension on the ip721
okay local Ascension view 721 foreign okay this is
[Music] interesting foreign
foreign it's just nice
foreign unlockable okay
this shouldn't really see a wallet foreign I'll be right back
sorry about that all right let's go Sanders okay we have a reference implementation nice okay on me okay so you can't relock and okay
thank you so I guess you should probably mention here foreign cool
so I think that's about all the time I have for today that's right yeah thank you Sam for doing this um for people listening to this call if you have anything uh input request form or if you have any question related to eip's hopefully we can see you in the next Erp editing office server which is on two weeks from now you can come and chat with us on ech Discord and leave your comment on the agenda so we can include your pull request to be discussed in the next meeting thank you all for joining have a great time