EIP Editing Office Hour #49
EIP Editing Office Hours · 7 Jan 2025 · 50:24
Meeting 49 of the EIP Editing Office Hour, held on 7 January 2025. EIP editors and proposal authors work through open pull requests and questions about the Ethereum standards process. This meeting covers ERC pull requests heading to Last Call and Review, EIP and ERC pull requests heading to Draft, a few small fixes such as website typos and the issue template, and whether to bring in pull requests from the EIPsInsight project board.
Topics
From EIP Editing Office Hours, hosted by ECH Institute.
Transcript
[Music] [Music] oh
[Music] oh [Music] m [Music] oh
[Music] [Music] a [Music] [Music]
m [Music] oh e
[Music] oh [Music] oh
[Music] oh [Music]
[Music] [Music] n [Music] to EIP editing office our meeting 49
this is issue number 371 I have shared the link in chat and we are joined by a few authors and editor Sam Wilson is here to review these proposals um Sam perhaps we can start with with the very first item um the last call and we are joined by authors of PR 791 and 792 if you would like to share your screen sure is that working perfect all right
in [Music] [Music] watching to be honest your voice is a little muffled Sam I'm not sure if you can be a little closer maybe use a head piece uh yeah I'm on Bluetooth headset
right now one second I can turn myself up I don't know if that helps a better a little better of course all right Prof e
yeah looks good to me there is another proposal 792 all right for
e e e there is a question in the chat for you
Sam uh yes you you wait for for the two weeks and then open a for request to move it to final okay so do we need to raise the pr again or something like that sorry I didn't really catch that my audio is terrible okay I will type the message yes I think so um yeah as Sam mentioned that uh you may have to wait for the next uh uh like forther comments that you may receive after 14 days if there are no comments you would have to raise another pull request to move it to final okay to final right with the status final or yes with the same okay
okay thank you all right so we can take the last last call here e
e for moving on to review section we are
joined by author for pr3 832 all right did you have any specific questions or just wanted somebody to take a look at this um yeah actually I have a a question regarding this I was running so once we move to review um are we still able to S make changes uh to the to the YC yes okay yeah okay sure sure that's awesome yeah yeah it's expected that yeah it's expected to make changes so while you're in review you're going to be getting feedback from other people hopefully um and then based on that feedback you make
changes right awesome thanks e this is a very good ERC number I don't
know how you got it generally people don't get this good numbers yeah I I know I'm we are very lucky here give me one one second I'll be right back sure no problem all right I'm back sorry about that all
right all right interface yeah that looks good
thank you all right 7818 yeah we can go yeah we can go ahead with sequence as it is there just going to review where expiration yeah expiration mechm um Sam just for your information uh the author for this proposal is also on the call okay do you have any specific questions or do you just want to
review uh this is m dxi i don't know how to say your name but yeah if you have any question please feel free to share just review no question yet okay the block [Music]
about [Music] that okay tell yeah so just
um make an implementation note here this isn't like a requirement or anything but um from experience with erc20 tokens um I'd recommend picking a specific one here but you don't have to um because obviously rc20 allows either cool and then let's go take our assets
here yeah all right seems good 7818 going into riew cool thanks that's uh looking
really good where are we up to next 793 yes perfect all right follow the owner non funable tokens signation
okay good this should think it's public and okay
okay [Music]
okay good test cases reference impation yeah this seems good so uh just a few um comments here before we go into review okay 4527 oh yeah so um I don't think we've gotten any feedback on this one from the other
editors yet let me check is it related to external link mostly yeah um I posted um okay
so yeah we have one person in favor of that um h there
[Music] okay so come back to that after so I can't review this one oh wait this is a typo maybe I can this one yeah these are very small typos I thought that we could put it before going into draft because draft will take longest longer time yeah so generally say a standard stack and I think on read not read me e.
ethereum.org it is a standard makes sense to updated yeah that makes sense if you template what is that duplicated there yeah we are getting typos for almost everything even for issue template any that makes [Music] sense this gives the opportun to push up thep to make proper yeah okay this is definitely a a good one to merge 7788
typo so this is active proposal perhaps in the draft status but there was very small type of fix and it is taking one PR so just thought of bringing to attention this is draft yeah I mean I'm okay with this um I'd prefer if the author approved it so I'm just going to leave it probably the same for this one too yeah yeah yeah it makes sense because this is like in the initial
state so author may want to uh merge it or maybe fix it in their next p or whatever is the preferred way to go forward exactly yeah they can they can do with that so all right that last one onchain up okay so this one
is um 9129 yeah so we should probably move this one to EIP I uh um yeah sure I will add it 9174 oh okay thank you um 203 okay I'll
second performance what is this four is my question yeah so for for
okay this for a second so talk this SL and see I'll improve modation this is why didn't this get merged I'm assuming this is an author it is so okay B transactions
okay see this is implementable this is very important piece of information I'm not sure many authors
are familiar with this oh the um cc0 yeah yeah like it can be placed in the asset directory definitely not in the proposal exactly yeah okay okay so how does evaluate Instinct work
here okay so how did your about okay
so okay I really don't understand how this works what is this supposed to do [Music] decision watching doesn't any okay so Instinct okay um um
okay finish the SE that we talk about that all
right and diffusive tokens just not oh okay so it's another one of these ownership doesn't actually transfer it just gets copied a transf chares okay good abstract
wa all [Music] right okay okay test Cas good reference
impation that's fine yeah I mean that's fine just few changes there cool so guess that's it for today I'm terribly sorry about my audio uh I'm GNA hop off and get ready for my next call I'll talk to youall in a few weeks thank you so much Sam thank you everyone for joining us today thank you thank you [Music] oh
[Music] oh [Music] oh
[Music] [Music] oh
[Music] oh [Music]