EIP Editing Office Hour #46

Transcript

welcome to EIP editing office hour meeting 46 um this is October 29th today on agenda we have a bunch of open poll requests on ERC to move it into review status and some on draft status we have already received request and comment for eight PRS and we are also joined by a few authors so let's begin with PR number 660 with sha Hong sure which repo is that on 660 ERC all right let's take a look okay I remember this one did you have any specific

questions um no not really I think we um Incorporated your feedbacks and we're just hoping to um see if um this current drop is okay sure all right let's go take a look okay that all looks good draft yep okay two interfaces yep great abstract okay creation management to participate

meaningfully okay yep that's all good motivation um okay okay

okay yeah so it's still a little um uh odd here in your your rationale section so um th like this section here like this paragraph here is is kind of um explaining what this function does um but it's not explaining like why you chose something so like I I'm going to probably approve this today unless there's something else that comes up but when you're um working on this in draft um the rationale section is meant to explain choices you've made so like like for example why you chose to encode um where is it here uh while you've chosen to encode rules as bytes memory um that would be something you could put into

rationale but like explaining what remove rule does should be in the specification section so again that's rationale should explain the reasoning behind choices while the specification is like what something does um but yeah everything else looks good so your license identifiers changed good this is in your reference implementation section perfect good yeah that looks good so I'll just uh leave a little note here for

but yeah otherwise that's great um thank you cool no problem where are we off to next so for next we have been joined by a group of 4337 contributor draw left a comment to the agenda and based on that there are two PRS for review PR 6 to 6 and 628 626 and we are joined by D Shaha and Alex from the team hey everyone did you have specific questions or you just want somebody to look at this okay okay no specific questions I think

okay okay cool so let's go take a quick look through this y That's good that all looks fine

okay cool um yeah that all looks good no more external link and I think everything else was taken care of yep done y fix that

one yeah okay that should be good and then are all of the checks passing they are all right yeah so just make sure whenever you um mention inline code like interface names or whatever function names put them in back Tex um but everything else looks good so we can approve this one and where we off to next 628 28

okay and external link y okay so this is probably going to be fine okay this is going into the ERC category all right set yep that's fun so this isn't like a hard requirement or anything but if you're if you use

comments in your Json if you just use um JavaScript instead it still highlights it but it doesn't complain like this um so that's good um I mentioned it before I mentioned again you definitely should put some Jason schema in here um just makes things more clear but not a hard requirement if you don't want to

um okay so5 yeah this seems okay um then I would add five5 in

here and then can I just make that change hopefully I can't because I can't edit it well oh someone's paying attention perfect yeah thank you cool that should merge on its own if it doesn't hit me

up okay great thanks yeah no problem I have a question with the team out of curiosity are we still planning to move forward with 4337 like I can see that in draft status right now or is that yeah so yeah exactly so this is why we separated the the these PRS in the first place because we wanted uh the other technical Parts the technical details like the RPC calls and the the aggregations all the things that are not core to 4337 itself be moved to otherc in order to find analyze the thec itself okay that sounds great so whenever you guys are ready it would be nice to receive a PR to move the status to

review yeah we are currently we are currently working on it intern we are just double checking that this is the final version that we want and then we awesome thank you so much thank you condition transaction it's a p [Music] yeah this

yeah so this y is way

topress smart contract shouldn't all um have you talked to the um calls people um because they have of

course different oh of course it's just um like if it is useful to specify preconditions for transactions it might be useful to do it here too that's just what I'm thinking not exactly when wallet this is an API between application and a wallet and send transaction condition is exposed by a node and okay it's a back end think of flashboard no revert private OPC but flashboard required to trace your complete transaction to know whether it succeed or fail and conditional gives you a set of storage slots that tells you that if any one of these changed

don't even bother to submit this transaction because it will fail it probably will fail okay that makes on the other hand if all those and since your transaction depends only on these stor slots just by checking the stor slot you don't need to trace and you know it will succeed so it give you a very strong guarantee yes we know that it fails if it's changed but we actually also can't assure you that it it won't fail and it's a cheap way to do it okay cool yeah okay yeah so probably want to move this in and uh get

that return okay yeah so again would be nice to see see this one okay turn value yep it's not good okay R

now yeah too bad you couldn't just provide like a snippet of evm but then it would become just as complicated as simulating the transaction um okay block Builder that seems good and then this just needs to get an s on it and yeah so if you make those changes uh while we're still on the call just let me know and I can come back and approve this because it looks good otherwise very well so the next we are joined by author

for two PRS PR 680 and 674 0x is the author who has joined us here you said 680 hello that's correct all right let's go and take a look okay did you have any specific questions no just looking for your your review sure I'll take a look CR thanks contract is under standard

registration management track grants e okay

track okay yeah okay yeah so I just say something like very early on just like what a grant is because Grant is a very overloaded term um program okay contract yep that's all good um okay enumerable

set okay grantee added grantee removed start dat okay so that's interesting so yeah because the the participants during a Grant during six months or maybe one year might change and you want all of them to be managed through the process yeah yeah that makes sense um okay where' that

go yeah I think this is the right one yeah that's the right one okay so um all right um what's the the GPL license Library um I forget um like Soul something G

it's not important but um um is it okay if I directly Implement only the Snippets of the numerable set that I'm going to use for this contract uh

yeah that would be fine um as long as you're aware of Licensing and all all that stuff that would be fine yeah it's okay it's okay yep okay what even is innumerable set what um what does that give you uh basically gives giv the idea that you don't have a list to manage it kind of Simply going to um provide to you if a set a set that you're creating contains or not contain and in which index that uh data that you're looking for is present so like imagine that Milestones might change during the process you might delete one of them you might add a new one so in this way you always have a track of everything and you never are

like missing index spots or relying on the race so does something actually return a one of these strs or match case that's why yeah no so nothing actually ends up returning one of these right yes yes precisely uh actually like during the research uh working with C Syndicate uh like we figured out that most of the times we putting some grants on chain you actually don't want to put a milestone so that's very that's nonmandatory so it had to modularize what kind of parts of a grant that you

want to have on chain okay that makes sense um so I think the easiest thing you can do here um if no functions or events directly use these structs you can just remove them from your interface you mean if she moved in through to the main contract uh or just sep like like don't put them in the um uh like in the specification section you can put them in a different interface or whatever just don't make them part of the specification so um all right

for for okay hopefully that makes sense um yeah

yeah it do cool so okay good then you have the RFC great okay of fi okay good set um okay grr okay that's good gas

optimizations to gener Grant ID using only the immutable identification field so how does that work okay so that's in your reference implementation yeah so same kind of idea here so yeah only out the idea okay yeah we'll apply soon okay okay good

good okay yeah I have a question regarding the security consideration I don't I don't I don't actually feel that uh needs further discussion but I don't know what what's the placeholder that one should put in the case um so the answer I'm supposed to say is um if you're putting something on a blockchain there's always going to be security considerations um but I mean I think a more realistic answer is like you can

say no security considerations were found or something like that um but like you should you should try to think about it see if there's like you know somebody could break it or or implementors need to be aware of certain like caveats they should go in in there um but if if there's absolutely nothing just say that you didn't you didn't find any yes simply don't compromise your keys so I don't think that's yeah exactly yeah so you can just say nothing nothing came up that kind of thing um all right all right so 682 let's quickly pop back to that and I think that should probably

have made the linter happy and it did all right so we can approve this one for now all right where we off to next so next we have another PR by the same author 674 674 [Music] yeah get ready to probably comment on my same mistakes on the previous

one well I won't repeat myself too much uh act contributions oh that's neat so it's kind of like if you don't participate in government and you like you lose your tokens essentially or something like that yeah yeah exactly most more focused on holcy than actually plutocracy undg to over time through participation okay okay the economic power speci trade

recommend okay so if you are recommended to be an erc20 token then you will requires 20 okay for the Tre function dra contract okay okay um okay create the event

missions create the respectives event emissions respective event adions on the pent contract from okay contract methods okay this okay STG oh okay so it is oh an abstract contract that's

okay um separ yeah okay so not T to implement it with either yeah okay so you do okay so I guess these aren't technically required readings so you

don't need to put them in your requires um but you do say recommended up here for erc20 so that one probably is um required reading anyways um the choice to okay inor game master mode okay grace good good discussion

Okay cool so for next we have received few more PRS maybe we can start with PR number 399 all right okay all right let's go take a look so including okay oh I remember this one

yeah okay the mechanism okay transfers so technically um these little things here are external references and should be linked but I think in this case it's minimal enough that I'm not going to complain about it

but yeah technically shouldn't be mentioning those especially isos because you have to pay for them to be able to read them um yeah it's fine here I think um so 165 165 good function transfer good transer from okay good animated might might is that a keyword now okay

exact points one must not expect one must not expect the trace for reference and locked reference data to be yeah okay reference data by 32 timee must not be anonymous

zero M okay so parameter y good parameter type is bites was B 32 okay that makes sense okay reference implementation okay um

this okay legal risks yeah that looks great so um feel free to fix these at some point um draft okay cool um we have a few uh proposals to be moved to the review status if you want to go with them sure um on the issue here Rus we can begin with that all

right hours I hope they will be quick reviews okay let's take a look okay there most CH my thought looking at Dex run here might not be that easy but yeah let's go with the review yeah this one should be fine uh can it back yep okay concept of a token standard upgrading procedure let's put this

in think my window's a bit too narrow that's F currently available different CH okay Define m k yep token [Music] converter yep be cont forever that we provide it in the text of this

proposals okay wait it's address be provided in the text of this proposal as to avoid any oh I see okay that makes sense um so I can just get rid of this

one all right okay the seem wait this is rationale is motivation this is motivation okay okay so I think we

need yep good third C standard this token converter Elin token development teams implement the standard yep at the same time cool the toor comprises two main components

um conver cont must accept deposits of yep that makes perfect sense converting back to [Music] yep yeah this all seems like rationale um good okay

it all seems fine um oh wait actually I mean it's too late now but all right let's go take a look at 7726 um I should just EXC Sam is muted I imagine yeah I'm back

sorry um okay this is going into review all right oh that's lovely um common quote Oracle interface for data providing the relative value of assets put this back to unified okay following that's fine base asset quote asset look good value yal addresses okay so

that is a problem there um 4217 okay so I will need to take care of that offline umut uh

ISO 4217 all right so we can't deal with this for now um okay 7751

okay perts okay yep I remember this one Curr contract yep yep that's fine um for

okay so just keep going down the list we have two more PR requested 663 663 all right interruptable delegated accounts I think this is going to be my last one for today um are the authors here and if so do they have any particular questions uh no they just requested in the chat but they aren't here yeah for

the interace to make delicated EAS in the mer 7702 okay yeah with 772 e execution abstraction okay expected mic cat okay yeah um

count IDs probably just be nothing okay for for

[Music] okay implementation um okay good good and then um okay cool and then so we were off

to 680 first and then and also Sam just a reminder that the next uh meeting is falling on Devon do we want to do it keep it or maybe try to make it in person I won't be there so um okay yeah right have it if you want to keep it I we we can skip it like if you're going to Devon it' be easier to just skip it I think perfect do that yeah okay okay all right so let's go and take a

look at this great perfect removing all the structs excellent just note about markdown if you just use one dot for all of them you won't ever need to Ren them um and when it renders it'll look nicely yeah that's that's great so cool Sam we also fixed 682 the conditional one what did I say about oh yeah this one's merged you're all good oh okay great so Sam there was 659 I

think this person has tried to resolve your earlier comment if you could may take a look right now or maybe you think it's all right yeah I can take a look um transparent financial [Music] statements okay what we talking about here okay um okay

yeah so this is probably just worth a whole read through again okay open trans okay cool cool um see 20 tokens representing you blockchain same function Comm as oil consum items spent their platform okay much token research okay that makes

sense 20 to represent shares okay stable [Music] cor [Music] definitions okay St coin address get sold operating expenses

for okay yeah that's uh thank you Sam and I have also updated the next agenda for November 26 um s can I ask a quick question to so we are now in the dra stage thanks I was wondering so what what it takes to move to the review stage um like um is there s um specific things that we should do to to made a pro request to

review uh so once you feel comfortable um with like your proposal being complete and you're waiting for um sorry let me start that over again um so you can move it to review whenever you want um it's whatever you're done working on the proposal uh so so um basically when you're ready for the community to read it maybe try like making some prototype implementations that's when you move to review um and it's whenever you're ready yep sure sure yeah thanks so much thank you no problem okay where's the ready for there you

are cool um I think that's about all the time I have for today so thanks everybody for coming out um I hope this was a useful call and we'll see you after Devcon thank you Sam thanks a lot thanks everyone