EIP Editing Office Hour #43

Transcript

this is EIP editing office hour meeting number 43 this is issue 355 on the agenda welcome Sam and I see you have already opened the agenda over to you them yeah all right let's get started so we're going to final those are always fun um transactions meta standard all right has anybody edited or commented or doesn't really look like it deadline's passed so yeah you can yeah should

probably get this a read uh representation object string representation place in the data field of the block transaction 444 new transaction yeah that looks good Med is represented as ajacent object curing to the following Jason [Music] schema good nice okay call data okay backwards compability yeah that all looks good so we can approve

that all right so moving to last call actually go 97 yep that's perfect Ro management here if you have any questions sure yeah um see to standard okay all right let's give this a quick read so un punishable token

rolles perfect this man each Auto time [Music] scan okay that's good mention to okay yep that looks good most inter the following interface you've checked your interface IDs they're up to date yes sir perfect Yep this is certainly solidity

that's that's good um 721 optional yep good an example perfect okay was false okay so that is defined good it's

not an extension of 721 good automatic exploration okay it's recommended to using Okay so this so this is 3341 okay um so I can't edit that for

you so you'll have to move that um and then there was supposed to be just a a suggestion should we make it a requirement oh so sorry um the the uppercase keywords here are um like I call I I say requirements but like they're they're um part of the specification because they're they're saying something about how it's supposed to behave so it should be in the specification SE c um yeah okay so it should be in specification that is recommended that approach yeah yeah because like so if somebody just reads your specification section they should get a good idea well

they should get the entire idea of of what is recommended what is what is required what like suggested all of that should be in your specification section um and that's true for all of these here um sorry I must have missed that before it's my apologies um um and then on a technical side um I will ask this on your discussion thread yes I want to revive the

topic um okay good um would it make sense to update the wording um because I don't

want to keep the um specification too big or too constrained but perhaps I can adjust the wording to keep it what it is what do you think like you want to keep it in well like they're kind like these are important information where' it go here yeah like these are important information for implementers like if you if you want you can just make this lowercase and then technically it it's okay but it it is useful information um yeah that's up to you if you just want to make that lowercase that's fine okay thank you yeah so otherwise that looks good I'll

um keep this tab open and I'll like let me know when it's um ready and I'll re-review it so we are joined by another author who has two P request open 542 and 543 it's for the second iteration 5 4 two there we go all right okay

yeah okay cool let's go take a look start with your assets good yeah perfect that's nice and small um yep good SP Cod efficiently all right cool uh the CP defines St interface

foring smart contracts on ethereum by the B okay assistant contract Discovery relies on addresses non deterministic good SEC okay [Music] hashes okay allowing developers to get pre for code base without disclosing the code itself

okay used ref okay cool yeah that's great um now what does this need to be in the RC um interace for smart contracts okay yeah I guess that that covers it um okay okay [Music]

back for Andro okay okay just yeah that's good I think um here can I just edit this I can so let me submit

this I will addit you and and we go in here we can remove this and then we should be good to there we go and then you said the next one was

343 right that's correct okay 543 yeah okay cool okay smart contracts nice okay good abstract

[Music] good uh contract must provide two functions okay main flexibility okay and

[Music] then nice okay that's good and then um change that after um okay good and and then cc0 okay nice okay and then okay and

then C20 protected Ray limit layer because this is deployment okay yeah that all looks good nice so yeah just a few formatting things not too bad probably go and do that for you the after call validation function great

then we had removing an external link easy enough so uh the reason why we don't generally allow external links is just because well in this particular case is because it would like unfairly favor your reference implementation um we've run into a few problems like with the rc20 where um people feel that open Zeppelin has been unfair like unfairly benefits from having a link um so that's why we don't generally allow this um I was I was doing same which is done in the the account abstraction uh like

4337 yeah they have example yeah so we'll have to get rid of that okay putting these here the trainer simulat

contract K the protected contract has bug nice okay no anything else I don't think there was anything else no that's okay cool so that is that

um all right where are we off to next Pua just back in order oh no problem I think uh Irani has uh made the changes Sam you want to take a look perfect yeah I ended up just making it lower case um I don't I don't want to I think there's too much read the specification I didn't want to bring more stuff there all right yeah that's get then uh this is going to last call yeah

so to move to final is there uh anything else other than the pr that we should do uh no just a PR okay thanks S no problem very well we have a couple of uh miscellaneous I guess three miscellaneous and a bunch of review proposals next sure so I put it under the category of miscellaneous because I couldn't find the best f for it but it seems like it should be merged sooner rather than later yes why hasn't this merged H2 proofer and ew so what is broken

with this 7761 h yeah that hasn't been merged yet that

would be why uh let's see 61 okay hopefully this is a quick one probably shouldn't r this one out of

uh order but I'm doing it anyways removes code introspection capabilities this makes it hard for 721 and yeah I don't think we should do this but whatever um okay so this would be a blocker right so better yeah yeah that's that's why I'm going through and doing this um set valid instructions 7702 oh yeah I guess yeah

that makes sense okay Target uh okay so we will count this

and then this one we'll have to wait until that one gets merged so will that be automatically merged after that so it uh it should once the other one gets merged yeah okay what is this this this olding liting I'm not sure what to do here it seems like there is one commit by vitality one by Matt and as per gend commment Matt is the right one what is the next step for the proposer or is there anything that editors can do on their end I have no idea what's going on

here um because we already have a hard f metap for Dan it seems something is not right we can perhaps close it if it um if it is needed but I'm not sure what is what is going on yes so this is adding linear evm memory limits then re it and then vitalic deleted it I just going to leave this one alone do you want me to add this in the EIP meeting because I mean I I I

don't know what like the the problem is the the goal of this PLL request is rather unclear I think it is I think there is a mistake in the title it's not like adding hard Fork mattera it's adding uh new evm proposal yeah no I think I think um Ginder here has done the correct thing and we're just waiting for vitalic to okay look at it again it's already have been marked as a stale so I thought it's better to bring it in into attention other than it's getting closed by itself all right I think we deleted this did we delete yeah this call for input is also closed but uh this is still

open yeah so if we got a e 7212 it's gone so we can just close this P request okay let me just check um assets 7212 so there's nothing there and then Eeps and then 7 21 two yeah we're good okay cool next we have bunch of open review open proposals for review status all right let's take a look at these so

this is from [Music] Tim moving to review for Network upgrade inclusion steps I think we had discussed some stuff here but I don't know where we settled yeah for sure so so must just should

here so okay this is more of an EIP IP thing but I well um okay think we I will add it for the next meeting as well all right for forr schedule for closure must be

renamed to included and contain only um yeah so okay for an inclusion changes yeah once the decision

is made by client te true should become [Music] quot um yeah okay yeah I think this is complete so I

don't have a problem with moving it to review but it is still being discussed all right 72 so 7742 what do we got going on here all right have CL verify B maximum have get Target value from CL all right take blob maximum wait you're moving to

review yeah so you can't um please t extion T stamp execution CL must EX for

okay so that one's done some ERC is moving to review all right all right solution implementing okay

so Layer Two Change featuring sub [Music] SP okay communication okay okay that's fine off chain

okay yeah this is I think fine for draft oh but it's going into review um yeah I think is probably fine 7628 yeah we should expect more review comments later on so that can edited yeah that's what I'm hoping okay fractional ownership introduces

okay this proposal introduces an attribute of ownership and provate share quantity s token under nft this attribute signifies uh stake in the ownership and profit rights of associated with the nft specific privileges enabling quaring yeah that's all good uh times to distribute dividends to with an attribute the number of ownership shares those for representation of ownership Stakes through the balance of a token held by wallet address contains the uniqueness of each token BLS an attribute to signify the shares of ownership rights okay all

right yeah I mean this is fine let's go and approve you 7628 7208 okay so what's failing in here non relative yeah well drop ability by

okay onam data connectors data object manager y NE TR okay okay

these are definitely requirements this is all reasonably well written yep okay okay cool um yeah

okay 7656 uh time to move to review all right okay let's see what's going on here General toing Services yep good okay this to

implement account Channel that's good okay that's all good motivation so find my support 7656 7 98 908 good token okay good this reference

implementation good nice this is going to review I think yeah so this can get approved cool so 765 6 so 6 734 um what's wrong with this one oh is this not in the okay one

so back over here ah yeah that would be my fault so let's go and take a look at that we go

into config and then ew and then we look for nest it's not there so we're going to for.com all right it won't be github.com it'll be SL all right actually is there a PO request already open for

this missed C no okay so I will add this to my to-do list and come back to it later all right one last in the review section yeah so I just got to finish this one here first um this is moving into review to that all looks good

token L wait work okay okay this is one of those standards um okay

okay neat okay so I think that's all good um there were only the [Music] one validator error if I remember correctly it's just the one okay so 322 Z

okay cross chain identifier specification um for for

okay all right so we have one proposal 517 uh that has been requested in chat by oh sure proposal [Music] okay all right let's get this a read okay

okay supposed to be scre create identity function the hash with their identity data um okay cont CA the verify to verification proof tations okay

okay [Music] rty [Music] okay this okay and then there's reference

implementation good so just a few like moving things around but otherwise I think this is looking pretty good um very go all right I think I'm pretty much out of time so I'm going to call it here um and I will talk to you all in two weeks thank you so much D we're done talk in two weeks bye