EIP Editing Office Hour #42

Transcript

welcome to EIP editing office our meeting 42 this is issue number 354 on ecat Herer EIP I GitHub repository on agenda we have a few last call few review and some draft proposals to be looked into we have a couple of miscellaneous proposals as well so we will get started thank you Sam for joining us today and yeah I see you already are sharing your screen so we can take it from there the first PR we are discussing is 498 and we are joined by the proposer of this PLL request as well 0x sure all right so you just looking for a review or did you have anything

any particular questions just look for RWS uh no questions okay time Bas all right proposal okay all right okay so I guess my first question for

this is um why does this need to be a standard as opposed to just a library that's something an important solidity I think that there's a lot of protocols using this as of now and it would be nice to give it a name I standard I people could use the same thing instead of random different contracts with different arithmetic Logics but I guess you

right this could be a library yes and hence like my question is what does it uh how can we differentiate a library from a RC is the Ala functions uh no so the the rule we use for this is um so imagine you have like two different parties that need to interop interoperate with each other so like for example you have an erc20 token and you have wallets um every wallet wants to support every erc20 and every erc20 wants to be supported in every wallet but um there there's not really

communication between the authors of erc20 tokens and of wallets so that that's a good place for a standard because you have these these independent people um who need to coordinate on the same uh interface uh whether it's one function or a milon functions it doesn't really matter it's just this this idea that these independent parties need to coordinate without communicating uh with each other um in this case um the uh I guess token or project or or whatever that needs this kind of curve um you just go and find um curve library and add it and they they don't need to interoperate with like a dozen different

curve libraries they just shoot CH the the curve that they want to use they read the documentation for that library and they're good to go um you don't need to connect together like you know my token uses uh any curve it uses a particular curve and because it uses a particular curve it doesn't need to talk to you know n different curve implementations so that that's kind of the the yard stick we use for determining if something is a library or a standard is whether two parties need to talk or multiple parties need to talk to each other without coordinating um and in this case I I just don't see that I think like this might be a good idea to add to open Zeppelin um because they have a lot of

these kind of utility things and I think uh that would be a much better fit for this dude I think this explanation was amazing thank you so much for it oh it's my pleasure um I think it makes tocal sense yes okay cool great well that makes this easy then thank you so are we going to close this one I want to keep it open for any reason I'm going to close it um all

right so the next one we are joined by uh the proposal for pr500 in ERC hey guys hey so did you have any particular questions or you just looking for a review um I'm asking to join it to draft because um I think it's plenty mature for that and the only problem I have is that CI is uh failing with an error that we cannot debug basically that's it take a look so everything's good here the first one yeah it's not required it won't stop you from uh merging yeah it just needs

an approval from from an editor so I'll get this a look give me one second just need to change where I'm sitting h okay Fe providing the relative value of assets like

that yeah okay okay good that looks great okay you mean that for the title

okay y easy okay okay God [Music] okay so that is going

to be kind of annoying um so I have to come back on this but yeah if it's free to access then we can we can allow links to it it's just there's a bit of process we have to go through um that looks good yeah everything else looks great um you can fix this whenever um doesn't have to be right now I can do it right now it's not a problem yeah it'll be the same for uh all of these as well like the errors um and then so so okay how can we do this quickly I'll just merge this

now um but it like so the correct thing to do here is is link to this ISO standard uh but the bot won't let you so um okay I'll just put a note in here [Music] ni that in A1 wow okay yeah yeah we'll have to like if it's free to access

there's no reason to not um allow a link to it so yeah we'll we'll fix that this is probably going to complain there we go do it again awesome nice and easy okay so so where we off to now Pua uh Sam we joined by someone who can uh who is requesting for a review of a different repository eapw if you want to take it later on we can perhaps check it later on and continue with our last

calls but works for me yeah okay all right then let's take the last call one and uh you may review the eapw whenever you get a chance by the way Al a if you have any question in specific you can perhaps drop it in the chat all right uh yeah we can look yeah sorry um yeah we can look for the question but Sam Let's uh continue with the call one thank

you okay and okay I can edit you all right okay so let's start by checking the discussions thread interesting here okay yeah doesn't look like there's any interesting conversations going on 7215 adding a d storage key that

information dat is stored okay okay okay yep neat okay Contra okay see you are

okay sure all exist um cool 7588 take look at this one okay interesting here no okay let's go get your discussions

thre okay all right object to the data field of The Blob transaction okay all right move the object description content type yeah that's find BL all

right BL protection first second BL okay yeah that looks fun so where does this go this goes in okay so where does this get okay is represented Jason data field okay callor

[Music] okay is fine sure can't edit this one of course I can't edit this one 7588 88 will be

20249 two weeks from now would be the third I suppose we have one more to go sure sure that's right

yeah and we'll just force mer you because I am an admin I can do that all right so 7588 and 2 4 6 1 I think some of the people have started using your trick of closing and reopening sometimes it work but sometimes it doesn't oh yeah yeah okay cool let's go and look at

this good see if there's any discussions I don't think there are June 17th no that's fine good [Music] okay so I'm pretty sure this was fine the last time reviewed it except for the interface ID is being wrong yeah think I significantly changed here PR 500 we can go back to that

hopefully this will still merge um I can re approve it though yeah yeah maybe we can give some more time I will make sure of not touching anything else anymore so once this finishes it should merge itself um okay cool I'll wait patiently and quietly okay it two oh this is me what am I doing here I don't think this one no yeah I'm just going to merge this so there are two of it like both are the

same thing or little bit different uh a little bit different oh that is a really nice uh commit hash um yeah so the one of the other ones um so Marius had one uh somebody else had a different one um but they both like were trying to do the same thing um so I merged one of those two and then I added a new PR to move it into review um so that's that's what we're dealing with here okay so in that case the pr made by marus 8796 do we need that anymore let me check probably not 7 six

[Music] this is moving to review uh yeah I don't think we need this one anymore [Music] 315 update mechanism versus system called This is an EIP what's wrong with this one this means so this is author approval Spectra upgrade proposal trying to move into review status yeah so this just needs oh wait

what you need yeah so this needs an author approval [Music] 35 so 6789 move to review okay so this is moving stagnant to

review but I'm guessing is this mered yet no [Music] yet so you to stay dra so we first for right so that itself I'll keep that open

just in case so 7702 oh my favorite all time this one just needs a review for me as an author that's weird why to pick up a match review on this or did it pick up match yeah there's a conflict um so the so the other one is 86 87 uh that also shows conflict I think these two peers needs to be looked together 8687 yeah this one here yeah so

just oh and it needs not auor approval but I can probably do that [Music] sh okay yeah that that makes sense um but I don't really know 7702 well enough to be able to comment on that so I won't all right 7656 for review all right let's do that token Serv Serv specific okay

variation 6551 that extends all types and services non tokens okay get that merged perfect re contract centralization Services consider okay generic regr the use function event name of any kind of contract Associated T okay that makes

sense no expectation to be as a singl allowing project to adjust the needs then Sports be okay cool that's a nice description so now I'm [Music] saying F structure okay CH the

oops it's not done [Music] well function good that's fine those are all explaining things reference [Music] implementation cool there's some code there I guess I was done nice 7 six 5 six8 do that

all right container okay data information data object cont manager separation data this sounds like some Java dat yeah like these are like forget what they're called um I well but yeah this makes sense okay

[Music] impation okay that okay and then 72

for for okay it's pretty

good we and then here there's actually quite a bit of discussion it's cool

for for all right

good 7208 this is when I literally just clicked on it is so for this oh I I think I made a mistake I thought there are two PR but I duplicated it no problem no no worries let's see what is this this is yeah this is EIP and they're making it yeah this is CH the order of chity and verified

contract address there's an error in signature verification of the current sample code is necess chain order bites chain ID and address this to comply with okay okay let's look at 72 and then we look

at the Domain type h do separ doesn't make sense see left out okay should be in the order as above skpp absent Fields okay so name version train ID name version so the new one is more correct these your agent should accept fields in

any order as specified by the vi typo FP 712 is like one of the worst it is a typo I guess I'm fix that while we're here okay PT any other instances of that

now okay make request for thatp all right soain type has is this which is main version sh address verifying contract yes this this makes sense but I'm assuming this

is a final EIP 2009 no it's staged oh okay so that's easy enough probably mov back into draft I'm assuming it used to be a draft

okay fres this here and sh okay

cool so I think the next one is UF proposal coming from obviously UF Team all right this ISP um good all right see this looks this is coming in as a draft or is this yeah this is a draft support okay cool let's see pictures

okay specification presented alterations in line rather than of differences be back going be a comp I'm sure Jason for for

okay okay uh open the outputs one Jon object perm operation executed the Cent must not outut multiple line the same operation executed execution must not out put a line for the Stop operation if an error occurred only the contract runs out of instructions okay which object Tak public numbers okay d

okay a PC cool good extion summ sum must as a must this of the following numbers okay ability Jason for

untain legacy contract change okay so we need the

oh did I disconnect there crap you're good okay oh it's not an e that's annoying not that one okay okay

security considerations yeah okay that's pretty good so we will com this cool so I guess we're off to P2P history Network there are two proposals like 8629 and 8630 both are from Portal Network t okay so PP Network okay so oh I did review this

one [Music] okay let's take a look 7188 is probably the other one just going to guess 7 77 yeah okay so do you have a circular dependency because that's annoying you don't okay so we'll start with this one

then generic framework over dis5 which allows new overload protocols to be built without reimplementing DHT Primitives dis yeah that's nice [Music] well there's no content here like there's there's no reason to have an EIP if the whole specification

section is empty that's right maybe we can add that as a comment I don't know most of the time we are listening editors are not reviewing I think we need to let them know what is missing there sh specifications

okay so with that like that that [Music] means this the same thing yeah it's the same thing right sign intended valid data

okay validator address according to erc1 version 0 okay it's great type data instruction approach seems complex three versions call zero okay validator

prefix data okay okay well there's no

okay that's fine approved cool neat was there anything else we needed to look at today P we covered everything here today yeah um I mean we would be looking into it in the meeting tomorrow I think we have came up with the draft of like uh the response time the number of reviews by editors that we have discussed in the past so okay your feedback on those stuff cool yeah thank you Sam I think it has been a

productful 1 hour for like we covered everything listed here see you tomorrow great see you thank you everyone thank you Sam have a good one you too bye