EIP Editing Office Hour #41

Transcript

welcome to EIP editing office hour meeting 41 this is issue number 347 on E caters EIP IP GitHub repository we have a few poll requests open for review and draft status and have received some comments by some of the authors who want their proposals to be reviewed so we'll get in there thank you Sam Wilson for joining this and helping us with it maybe we can start with uh PR number 536 on ERC repository as I see the author of The Proposal is right here with us sure so let's see what this is about did

you have any specific questions or you just want somebody to look at it uh actually the warning you see there is one question I was sure about this was also in um this just name was kind of or the description was inspired by the 2612 so the permits you see and there was fine so I guess it's like a new check anyways I wasn't sure how to fix this oh yeah this is this isn't your fault this is a side effect I guess of when we split theps and erc's repositories um yeah there's really not much you can do about it um set operator yeah okay all right uh so yeah as long as you reference UMC

like or EIP uh 712 um you're going to get this warning um it's not the end of the world it just means that an editor will have to override it um yeah so sorry about that um all right authorized operator okay okay looks good looks

good okay instead of function to aable metat transaction topic interactions with contracts implementing an operator model via signatures conforming to the type okay that's good um okay the prim motivation the C of

the did you use chat GPT for this it's not a problem if you did I'm just curious no I think it's rather bit coped from 2 or 309 which maybe that one use we didn't we we definitely didn't use but we did copy a little bit because it's very similar to 39 just different purpose and yeah oh it's fine I'm just curious it like it loves putting in this like block blog here or block whatever um the for unch is very like similar to 39 I think yeah can improve security stand for dat

signing y okay the authoriz operator standard aims to stream the process meur operator okay this signed authorization contract interface yeah this is maybe actually have a question about this this is a little bit tricky so we designed this for e7540 which was recently approved and it's kind of an extension for that 7540 has an operator scheme which we

kind of copy it from 6909 really ideally in my mind six this operator scheme should have been a separate OC but 699 just included as part of and we kind of have the same implementation like the same interface so the way I wrote this is like okay so you have this like interface that both 699 and 754 do so we kind of this standard works for both but really ideally it would have been a separate I don't know this is how we thought about I don't know if you think that make sense or how you do this this is fine um yeah I wouldn't worry too much about it it's understandable the way it's written so that that's good enough for me okay good [Music]

um all right okay permissions for auth reest Mr sender using yep okay okay 26 12 yeah no this looks good um

me just uh I can't edit this for you um yes so I guess just fix these um at some point um before going into review otherwise I think this looks good yeah all right thank you no problem so the next one yeah please go ahead yeah just uh try to keep your commit history um cleaner um just makes it a little easier for well I guess it squashes anyways but uh yeah yeah yeah I never understand why dust is actually to

be honest but I think it's merged in um you you made merge commits with um Master instead of rebasing and it makes it all confusing yeah yeah that's fair okay we do cool well so the next one requested here is the pr number 537 it is a proposal moving into the review status all right let's take a look at this secure medicine prot mes between users all right uh SE register there standard interface

okay okay okay interesting yeah I mean this is fine um probably have some yeah and also it is just getting into

review status I'm hoping that it will get many more reviews there yeah okay so let's make some technical comments here um and I guess there is all um just give me this no it's not what I wanted give me a search there we go I want posted by I want to find things I have posted

there sure okay so we want probably to say um [Music]

okay key algorithm and then I also want to talk about um algorthm um

cool cool uh so the actual this is the wrong one this is this is the right one okay so for okay

perfect all right so so there are a couple of more proposals for review that has been added uh that is from EIP it seems like smaller one may you want to take a quick look sure 7610 right P request for that [Music] one 610 there is all right so we'll start with this one revert Creation in case of non-entry

empty storage okay creation an address with pre-existing storage y contract creation is attemped create transaction the create up the any other reason the destination address already has non zero non creation must okay here all right sure that looks

good okay so this is retroactively included eips going into review okay I mean sure I'm still not very happy with this being here but it's fine all right from St um we have been joined by a couple of

authors and the pr is not included in the agenda initially but the number is 542 and 543 of ERC Repository I'm going to add them right away okay did you have any particular questions about this or just uh uh be Sky if you have any question you can share that or if it is just for a review we'll get it done today ah uh yeah so you'll want to use uh EIP

um instead of ERC and then you need to link to a file you can't link to a directory unfortunately so generally I recommend people link to their read me um and then you can kind of go from there um 7744 readme.md and then let's call this like yeah so that should fix it um and then you can link to all the files in your reference implementation from your readme that generally looks pretty nice um yeah so let's go through this so code index

indexing smart contract by code on ethereum okay so we need to get a little bit more information here so um you generally don't need to put on ethereum we kind of just assume that all EIP these are ethereum related um okay um try

okay good that looks fun the CP defines the standard interface for indexing smart contracts on ethereum by their B code hash this en trust verification contract code facilitating use B code signing weight listing decentralized distribution mechanisms okay assant contract discover relies on addresses which are not deterministic re off get through proxies indexing by bik code hash provides deterministic to identify verify smart contract code okay Global by code identification sufficient to build requirement to build efficient at high scale Global factors for future software okay

um for okay so that's good so index already exists okay so you

[Music] register uh so you you can't really link to random repositories and stuff because we we've had a lot of problems in the past with things uh disappearing and getting deleted and whatever so um the short answer is no don't link it um but uh if you can just put in a little English text here about um why somebody wants this that would be very much appreciated and uh do we think that this link if they really want to add it can be added to Fellowship of ethereum magician for people to get more reference but for the documentation purpose just in text English text yep

I'm very sorry there was just a loud noise and I had I I missed 30 seconds of your message oh sure um generally we don't allow external links because they have a tendency to disappear or um get changed so uh in short no don't link your uh repository um but if you can provide uh just some English text uh in the in the document about why somebody would want that i' I'd appreciate it okay so to index contracts by their

bike code okay for Okay so

Okay so deployment method okay um okay so reference implementation that's good

okay yeah um okay y same here yeah definitely remove this one um okay so this is deployment St

um yeah okay okay and then and we have code index all right yeah that's fine this by okay we have test

test okay okay so that I think is everything um going to mark this as request changes just cuz um yarn log files are huge and we don't want to bloat the repository too much um but that's the only like serious issue everything else is okay um great there is one more 543 543 all

right composable security middle Warehouse an interface for composable runtime Security checks and smart contracts that's pretty good um okay is from implementing compos SEC lers middleware enabling runtime validation function costs before and after execution independent okay current smart contract the contract itself okay okay that's fine that looks

good all right must provide two functions okay prot contract m security lers by calling the before call validation function before executing it logic in the app call validation function afterwards must revert if any layer reverts all right okay okay um

so player proxy layer okay yeah so let's go to your reference implementation here and say

um so if the tests are useful for other people implementing it um you can keep them and I'd recommend keeping them even if they aren't they don't build or run um people are are generally smart enough to figure out how to use them um but if they're very specific to your particular reference implementation and they aren't um useful for other people trying to follow your standard um then then get rid of them you just want to keep um the reference imple implementation as small and and uh concise as possible um

that's up to you I think I think in this case you can just leave like you can leave that as you know implementation to find how they want to to do it um it's up to you if you want to include it or not um okay and then go here for for

uh what do you call them security metal wear hooks uh layers yeah for all

right cool um do we have any other uh authors here or should I just keep going through the list here yeah we don't have any more questions in the chat so far but we can perhaps take a look at this stagnant and one meus yeah this is coming out of stagnant to review all right and if we look at the history of this file yeah okay so review

perfect so it's moving into informational okay information defense safe range ma okay I need this in split view there we go uh we want CH to be save okay pack enable possible expion okay yeah that seems great cool that's

easy get that merged yeah it's good to see people are trying to pull back their proposals and bringing back to life and active discussion yeah exactly okay Stant back into review and let's look at the history make sure that we're going into okay so you should be going into draft okay okay so this can be approved

okay so what are these two links are not updated I assume this will break everything yes this will break everything so we can close this [Music] okay moving from s to

dress okay yeah that's great merge away okay thank you no problem add instructions for more th lunter oh wait is EPV still in the read me at

all that's interesting yeah okay so we'll do that and approve

all right um backwards compatible Quantum backwards compatible postquantum migration that's a mouthful all right um yeah so this is stuck waiting for a patent Grant we cannot merge this without one do we want to add any comment or has it already been added sorry I missed that part oh yeah it's um the last thing I said is um that so just has to

wait uh create op code create okay yes there's been no changes on this since my last review all right okay so decentralized identity verification three more reviews what what do just need three reviews I think from here on it is just copy paste from the last meetings so yeah we can take a

look I think this is in the wrong directory yeah this needs to be inc's okay assuming somebody mentioned that no okay so there eum blockchain that's yeah okay

gooded e [Music] blockchain um okay this propos stand for decentral blockchain secure okay cool decentral okay um see you thanks for coming out uh you

should include a bit more detail the differentiates this proposal from others uh similar um okay and if we go in here I'm pretty sure there are some no okay dead yeah um

okay 3 address of the user okay identity created identity verified create identity get there okay okay I mean this is fine but I don't think it provides enough information okay um

um all right simple permissions checks

it's a lot of merge commits um all right what's going on in here can okay check us your permissions okay the F provides a standard generic method for checking whether a given account has permissions on contract this can be used for

permission [Music] toiss token [Music] transfers okay TR user permission to indirect contract okay I mean it's fine it's not super detailed but that's fine yeah all right I think I'm going to wrap it up here um I will guess I'll see everybody in uh two weeks thank you Sam it's really helpful

to get more p request much and answer the questions that some new Authors may have thank you so much for your time see you that's my pleasure see you then