EIP Editing Office Hour #30

Transcript

welcome to EIP editing office our meeting 30 this is issue number 301 on eat cat herders EIP I GitHub repository we have a bunch of uh open PRS to review and to make status changes Sam yeah if you could please screen share thank you so the first PR we would like to review is 187 on ERC GitHub repository we are joined by author uh Ste to discuss this pier hi there hey how's it

going good good did you have any specific questions you just wanted somebody to look at it uh no I think it's already uh just of course I want you to take a look at it and you always find good suggestions and merge it as draft all right 20 tokens okay so I'm assuming you've seen the deterministic wallet owned by an NF

proposal uh 65 51 uh I'm not sure 6551 yeah that's the one so you have seen it all right yeah yeah that's good yeah this is much simpler this is uh meant to be as an extension so you actually need to include it from uh start which is a disadvantage but it's way simpler which is the reason we are proposing it okay Mak sense and this is just focus on on ER c20s since they don't have a a call back to notify the the receiver contract um this is we find this necessary okay yeah

okay the ever 721 team [Music] okay extension composite transactions okay

okay yeah I think I had a connection issue so I'm not sure if you ask oh no okay directly to the n confence okay good and [Music] then can you relicense theoda cc0 or no

this is just for we use on our rippo and I forgot to to replace it okay but I change it thanks yeah same same for all of them obviously um got some tests cool yeah so just uh fix those and uh yeah should be good to to merge as a draft nice I don't know if you okay I I'll shake and maybe ask more questions sure thank

you very well the next one is the pr number 163 and we are joined By Conrad and that is on ERC that's right did you guys have any uh specific questions for me or just um have somebody look at it yeah no specific questions either just like a general look all right okay so

first off it's getting a descriptive title and description is really hard um so um

um to discussions two okay this propos require integration of behavior for mon smart accounts modules to ensure Okay so contract accounts are getting adoption

accounts being built using modular architecture these modular contract accounts after smart accounts move functionality into ex contracts modules in order to increase speed and potential okay different ways creating module fragmentation and ventor lock and to solve these problems we need to standardize the core interfaces for smart accounts modules okay the goal to Define smart account and module interace interfaces and behavior that is as minimal SP okay good so a module validator entry point okay so this justed how

validator selection ised forcep operation Fields okay to okay count configurations for authorization control install installing

okay SC option okay drop [Music] 7140 and 1271 is of course in your requires perfect uh fallback fallback can okay that looks good H Okay

so okay that's fine good okay specifications okay that's

fine that's fine security consideration

some initial [Music] considerations looks good milous HS Okay cool so kind of a similar comment on this one um all right yeah that's great so just those few comments on here and then it should be good to merge as a draft cool thank you um I have one question on the reference implementation

actually yeah um if it's kind of like a complex like I guess like usually like multifile um solidity contract should we just put it all in one file or should we just put multiple files that inherit from each other so I I I ideally you'd want to keep your reference simple implementation as minimal as possible so you you'd want just like the the simplest thing that illustrates your your EIP um so ideally in one file I mean you can theoretically use as many as you want but um try to keep it as small as you can okay cool makes sense thank you the next one we can take a look is the final proposal listed here and then

we can go sequentially there one small comment maybe before or after this one uh I updated the how and the other suggestions but especially if you could look at the how some it's 187 uh 187 thanks yeah that's perfect yeah yeah know that's that's awesome

yeah thanks for making that change let's go thank you okay looking to final all right [Music] okay good

okay do you have a test case that covers this you don't okay well I'm just going to have to trust you change State refence [Music] implementation yeah I mean this seems good to go thank you so we can go ahead with the next one the last call one sure Mo the last call address placeholder for e oh right

this one okay yeah I mean I guess that works

um so we are we may have to change the deadline yeah we may have to change the deadline yeah all right so what is this this is which is just okay from Berlin to chapella so it's just like a meta one like earlier we used to have meta EIP

per upgrade but we stopped when we migrated to execution repo so it's just to let people know that we are coming back again and whatever EIP whatever upgrade is not listed and meta file they are trying to listed here yeah only one concern was with 2070 because there is already a meta for 2070 yeah so yeah I mean we can't really do that um do you want me to take it move it for

the eapap meeting we can perhaps get some oh no no it's it's um okay just we just have to move this to with drawn there is another there is another PR open for it to move it to withdrawn but it's waiting on Ax approval I think it's been a couple of weeks at spending over there okay so yeah I'll just um

there's the um 27 27 day okay draft review core

I'll just leave that like that [Music] okay live okay this is going into review so what were you before 6224

raft so it's going from stagnant into review I guess that's fine just means I need to read the whole thing um system manage it smart contracts the system cons two components contract fory start reference contract used within a protocol option making them upgradeable sub box on top okay that's fine good NE 3 ecosystem projects tend to become more and more complex protocols

require portability and Agility okay a career architecture of faad and there's a mixing position okay let's see this diagram here

contract make contract must refer Lo contract cont may be configured to okay must implement the following interface nice that certainly looks like an interface okay for sh contract must inherit dependent [Music] okay and

Oh wait we're in rationale now all right all

right was there anything straight up blocking in here or is this okay to merage yeah this is all right so was 6224 6909

after this maybe we can take a look at one of the draft proposal which is mentioned in the comment to the agenda yeah sure yeah cool and then you want to go to the

comments down here yeah so the number is 1 15 of ERC Depo 1 15 okay yeah cool let's take a look okay

no it seems fine um there's just comment can okay so we have addressed everything

added to the comment and there are a couple of more miscellaneous actually three miscellaneous PR if we can quickly take a look yeah of course how's my video quality by the way I'm trying a different way of of streaming so I think it is good but one thing that I mean I missed to say it before we should perhaps increase the font because generally we are looking at your screen and the font are low when we are looking I mean like yeah I can definitely yeah yeah this should be good y otherwise video quality is all good yeah audio video both are great good good um so sorry which one's these two

drafts here or yeah uh the miss L is I think we have covered yeah I think we have covered all the only concern is the proposal I guess are in final status so yeah exactly okay so we'll leave that for for

later let just close all my other tab here yeah right yeah that would be good we can do it there yeah so next one is again a small typo for the final proposal erc1 yeah I think that's uh that one's fine okay so uh this proposal is about like fixing the ERC s. ethereum.org page currently it has like it is a copy paste of e.

ethereum.org so they have like lot of additional thing which is not needed there there are empty tabs so kind of clean up and just to make sure everything is all right but it would be nice to have it reviewed yeah before can yeah so I can take care of that um yeah yeah this will have to be offline okay cool yeah so um I guess there's still more time and still more proposals so there are three more yeah if you have time we can perhaps take it there are two core proposals and one ERC okay so I think

um G gender's already looked at this one here um oh it's this not in the right yeah this isn't in the right directory yeah

all right then generation unit 64 eoch all right generation year 64 a generation is a scale version of epoch

okay this posess introduction of a new terminology yeah this is interesting like I'm not sure if it is actually being used or if it is then it is great right yeah because generally in informational EIP we try to add which is already existing right it's not that we are trying to propose something new yeah that that is a good point might want to maybe um get it

reviewed by some of the seal so if they are actually using the term generation there so then that makes sense yeah okay ration now yeah and

then um all right I think that is about all the time I have for today um so I will be back in about two weeks thank you Sam thank you everyone for joining us today have a good one thank you guys thank you