EIP Editing Office Hour #3

Transcript

welcome to EIP apprenticeship office hour 3. thank you Sam Felix and John for joining us today I have shared agenda here uh Sam if you would like to maybe pick up proposals or pull requests from there sounds good so I guess let's start off with uh 54.89 foreign yes it looks like this is just waiting

on some yeah okay yeah so this is just this used to be fixed not much else to do here right that is the only proposal for review this week yeah let's move on to 22.94 and if anybody wants to you know jump in ask questions or whatever please feel free um foreign

[Music] foreign [Music]

yeah so I was wondering if a possible solution to this kind of problem could be like uh in words instead of using these symbols to maybe directly provide the link so what do you mean meaning uh the person tried to add Fellowship of ethereum magician length so they can just write uh like the website the name of the website Fellowship of ethereum magician and under bracket the issue number it will not provide a direct link but it would not be hard to find like yeah that still has the same problem uh like of linking to something all right it

doesn't really matter how the link is created like a if it's a you know HTTP link markdown link uh you know an APA style citation they're all the same like problem right so right yeah wow yeah we need a permanent solution to the question yeah yeah so I've actually been kind of writing up uh like an EIP on how to do external links so we'll see how that goes over at the next call I guess nice yeah um foreign

[Music] oops okay so anyway why is this being added this withdrawn here repair

okay um I I'm not sure I went through this proposal completely but is it two to nine four right so which was earlier by some other author and this has been this is being championed by uh Victor I guess right yeah this this one is okay so I have added one um PR to Beta bit IP meeting it seems like there is some kind of confusion related to uh the number to be assigned for any proposal looks like this particular

proposal it was started with issue 2294 and that's why uh Victor tried to get the proposal number sorry the EIP number as 2294 but because this was closed looks like another editor is not in agreement to provide the number 2294 and the request is to move it to withdraw status and then come up with a new EIP um I think we can yeah because this uh the earlier way of doing it was like whatever issue number or whenever that proposal is being discussed first pull request or issue number could be provided yeah okay I think I think we can bring

this up after um right because I have added another example of this for the eipap meeting I just missed this one okay yeah I'll bring that up with panda but after um okay so semi-fungible so bound token see just need to review that's pretty easy and no comments yet so let's go

all right this is a big one just looking at okay so an interface oh some more slowbound tokens okay interface for cell phone tokens which you don't representing the person okay governance property protection company expression and account recovery this interface systems okay and okay then there's some tokens

okay so there's a slot okay do they have any description of anything in here I want to just interfaces it's just interfaces okay so I think [Music] so for

specification section of a little white details um oh okay foreign

permutation combination of fungible non-fungible same mice power Soul bounds and tokens yeah I know and every combination gets its own EIP it's great apparently okay foreign

I don't know if you guys can hear me but uh I'm just looking at this right now and I was trying to understand the concept of slots and it's a very so that list of the um features at the top uh the very last one it says the grouping of svts using slots so I was trying to figure out the data structure and from my understanding the idea is that a token uh can be within a slot so multiple tokens can be within one slot and that represents a group and that is their way of handling grouping interesting yes I think I think that definitely

needs to go into the EIP a bit more than just this one little sentence because it's kind of a very unique concept yeah it is and it's not immediately recognizable unless you like to look at the data structure and the event that restriction think about it [Music] okay [Music] foreign the which ones right sft the

semi-flexible token oh it was it was approved it wasn't like there was a it wasn't the the uh the another EIP and I remember the number but it was approved was it a was it also Soul bound or was it uh it's not a cell bound it's not just general effect like compared to um ft and nft this is the F sft okay so that's not all the idea they they introduced let me let me find out the number VIP number oh it's a 35 25.

ah okay so um so I think a lot of that is defined from this EIP then right okay this one is just submarrying these uh the uh sft to uh to uh yeah okay great so yeah I think my biggest complaint with this one is just um it doesn't have enough like meat about what the uh the proposal actually is but

that's all right so [Music] um oh yeah it's literally right here at 35.25. [Music] um okay

which is okay I have recovery mechanism so do they have a recovery spiral recovery okay is huge pattern and taking this one unit control okay

foreign and it's fine um okay

it's a temptation um thank you that seems fine [Music] um

there's a lot of stuff in here okay let's see here okay so I think this is the one they linked to and hmm

oops this doesn't actually seem too complicated for all the features that it has um some might be okay with doing this is the new concept of slot like just adding yeah 35 25 was like I'm introducing this slot idea yeah I think I'm okay with this and then pretty minimal hard hat config that's fine that seems okay sure type script

yeah it all seems pretty reasonable all right Okay so 57.27 let's move on to 57.25 hey another variant of nfts where do we leave off on this so oh go ahead the interface transfer investigated

teams which means okay easy enough just to check in looks like they were having some issue with C I didn't and otherwise yeah yeah they're looking to they're linking to a whole directory you have to link to a single file which I think is what uh like what it

said down here yeah okay why does it say one pending reviewer oh because there was a request for panda paper was it the reason um what did you see what did you see then so I mentioned I mean I saw in a comment uh where it says Panda pep taking care of it can you confirm if this can be done or not and after that I don't see any comment from Panda p and I'm seeing that it says that one pending reviewer

so yeah so the one penny Reviewer is Eve but it's forever yes yes yeah because I was wondering like this is in the draw this is going to be in the draft status so why it requires multiple reviewers yeah it's just the one so yeah I feel like there's another EIP from like years ago that does something similar to this um okay so this is kind of the opposite

right so instead of having an nft represent like a bunch of erc20s this is a bunch of erc20s that represent shares interval okay interesting okay holder [Music] being investing contracts okay

yeah I'm standing alone [Music] foreign a little bit

okay let's see here's the 721 that's in the choirs I'm assuming so yep I have cleaned um okay turn on tokens which I've invested at

the current time stamp s okay sense all right that's something which will probably asked separately so we'll do that so I'm worried that this um vested paired at time might be difficult to compute if you give it an arbitrary timestamp so I'm going to put a comment on the discussion Thread about that

you're right okay foreign [Music]

this texting tools um today what's your functions so these are defining um actual Behavior I think um foreign

[Music] thank you [Music]

yeah that's rational that's good that's fine this can be removed foreign foreign

foreign [Music] I wonder if we need I guess it's okay let's see

it'd be nice to get these tests in a format that's more but it's not really a standard format for tests so there's not much we can do about that um they can just write or run hard hat test it's just not great all right I think that's reasonable for this one okay I've got a quick question about uh tests do you guys normally just see hard hat tests and that's the like standard way of testing things or do you ever see uh Foundry kind of like dab tools hvm tests

yeah we've seen quite a few different ones I think we had our first founding one within the last like two months or so um ideally we'd like tests to be written in like an agnostic way um but there's no real standard for that so we just accept whatever people give us right okay thank you yeah they're mostly there for um core eips which have a you know rigidly defined testing structure so for those ones we care a lot more things passing I'm just looking for

okay essential business interface so I think this is technically an interface EIP then I don't use those very often yeah because that's requesting some changes at interface level right yeah exactly

okay time as soon as you may need to be mutated [Music] um okay okay the wallet contract must implement the

following interface okay that alternate signature um a block.hash in which the signature should be valid hmm this is really weird I don't exactly understand how this and Jason blob is supposed to say if I keep reading and probably explaining so claim isn't actually going to hold the signature into developing trivalic

foreign [Music] the car fails anyway it's not Valentines what does that mean tribality with

signature using e1271 if the signature is available in the center cap then you get the alternative signature and the alternative signature gives you back a blob like a new signature in it oh okay um foreign

yeah yeah [Music] okay so I guess there's the other person okay which means foreign

foreign all right so that's that um okay I think I'm going to have to wrap

it up here for today um getting a phone call so I will um I guess see everybody in about two weeks uh sorry to cut it short I look at it I have listed a few other proposals uh if you get a chance it's going to maybe look into that that would be great thank you so much thank you so much and yeah see you all in two weeks have a good one bye