EIP Editing Office Hour #22
EIP Editing Office Hours · 8 Aug 2023 · 1:10:07
Meeting 22 of the EIP Editing Office Hour, held on 8 August 2023. EIP editors and proposal authors work through open pull requests and questions about the Ethereum standards process. This meeting covers EIP pull requests heading to Final, Review and Draft along with miscellaneous pull requests.
Topics
From EIP Editing Office Hours, hosted by ECH Institute.
Transcript
welcome to EIP editing office our meeting 22 thank you Sam for joining us today I've shared agenda here in the chat and the number is uh 251 on eipip GitHub repo um thank you Sam for already merging some of those PRS before this meeting and we are also joined by Stephen I think uh there are two PRS that he would like to be reviewed number one is PR 7414 um maybe we can start with that sure yeah I'll take a look did you have any specific questions uh yes so there is a uh an important caveat about this uh this is meant to replace 6059 which is final but we
missed a parameter I think you might remember it so what we're doing is we created a new VIP with uh just basically the same just the minor fix but we are taking also Panda Pep's suggestion to use a number which would like which is related to the original one so the original is 6059 we are proposing 1759 uh it doesn't match the the pull request but this pull request uh it it's it was not an EIP 1759 so it shouldn't have any conflict with others and we added these information Source just as uh 1820 has it because it
replaces 8 20. okay um so it was already merged as a draft right at seven four zero one yeah yeah those measures that they're off already okay so I don't think we've ever renamed an EIP before um so this will probably have to be a discussion for eipip tomorrow um I don't feel comfortable approving this um yeah okay we just want you to have it in in the rather yeah because this this was done for eight to any in 1820 and then uh well Panda pip suggested yeah you probably need to discuss but
yeah okay so we can look into the next one that is 7409 and I will keep seven four one four for tomorrow's agenda yeah yeah on the other one we're doing the same so it's also uh an EIP to extend uh another one which uh once in production we realized we were missing uh part of the purpose it's uh on a repository for emotes uh but we used bytes4 for uh gas savings but later we realized that not all emojis fit on four bytes so we had to change it to string but the other
proposal was originally final so it's the the same thing so I guess also for tomorrow this is the draft yet yeah so that one I can do oh okay it's just because it was a draft so that makes it different I'm having trouble getting my zoom thing to disappear here so give me one second now let's try this again you think after you know 50 years of computer technology we'd be able to screen share nicely but uh unfortunately not nope okay well whatever just move this down a
little bit sorry I think you're sharing only this yeah yeah that's that's fine it's just the um the little the little panel at the top that has like the mute button and and all that is um it's hiding my tab so I can't click on anything uh so what's the the pier okay [Music] I mean worst case for the other one we can just well withdraw it and create a new one but it
doesn't have much sense just to change the number so yeah you're asking for 7381 for this one okay yep and then I think there is um foreign we have a new way of doing EIP numbers and I want to make sure I'm not uh
stepping on anybody's toes here all right well I can deal with that after okay yeah so um yeah I'll I'll take a look at this one offline um it should be fine I'll just check with everybody and uh if it is I'm urgent right uh so for tomorrow is that a public meeting or it's internal no it's public you can come I wouldn't recommend it but you can definitely come on okay I just uh I just wanna uh make my case but I I mean by now you open the bib and there was all other editor there should all be aware of of the mess of the
problem with with the 6259 because you were all part of the discussion yeah okay cool great thanks for your time time so this is seven four zero nine yeah thanks for coming here seven four zero nine okay so what are we off to next so the next is seven three five three it seems it is already merged but the author is here with us and he has some questions for you sure yeah hello everyone uh so yeah we just moved our seven zero double six to review using this uh PR I wanted to understand what are the next steps in order to you know move it ahead from the review phase as well sure so
um the EIP process is pretty author driven so um right now would be the time to go out and get like feedback from other people who'd be interested in implementing your EIP um once you've done that you feel confident that there aren't going to be any more changes uh you you can move it to last call in the same way that you move to True review here and then um once the two weeks is up you can move it to final um I do want to stress that you want to make sure that you are that nothing is going to change like leave it in review for a while get some implementations built um you don't need to go to final right away it's not a race because once it goes to final you can't change it
yes so we are already working on two applications soon to be on production using seven zero double six we have had couple of discussions on the magician form as well okay so I like to write things over there if Community has more feedbacks on it yeah and then you know once you're satisfied you're ready and you're sure that Nothing's Gonna Change just open a PR to move it to last call got it yeah that's it thanks a lot my pleasure bye all right uh so I think that's all about it and now we can go as per the sequence I guess there is the next proposal PR number seven four five one for review
oh yeah this one just needs um okay did I really review on this one I did yeah so we can pull up [Music] episode seven four five this is the one I left off at I think it was yes this is the one I left off at all right so let's see what's changed so we're going from draft to review we're adding some authors um
okay okay the erc721 standard enable and explosion non-punch applications this is the ownership one aims to give every adverty the same as a cam okay so that's fine super threat issue for talking about accounts okay 67 167.
foreign the deployed by code of each token shall have the following structure okay perfect one the contract okay so this is going to review so going for that assistant
foreign [Music] interference so we're indexing some accounts okay that's looking good we have a new ID that's fine excuse me I'll talk about accounts must
implements and execution interface which allows valid science execute arbitrary operations on behalf of the account support for an execution interface must be signaled the account you see ic165 okay so it's optional to implement that one okay Singleton registry usually create your own code cross chain compatibility okay I'll talk about accounting creators if
you drop code enabling accounts to exist again prior to their Creations laptop gotta catch receive access okay okay single I'm going to search three insurance that only the pressure to count for any tokenbet account is the implementation the sketch is a hold of the token next is childless and start with the mechanic okay same with my insurance okay does not required to perform
let's just click it is okay and then there's that good okay that seems very reasonable all right it looks like you have already responded to 7449 perhaps we can move to the last one under review section which is 7437 oh that wasn't this one 7437 that's right okay
move to review okay so I think we have so are these miscellaneous ones yes we can do that and there are couple of proposals which are in draft from the past meeting and an author have requested to revisit that so there are only two miscellaneous India we can probably cover them and another one is this for a final EIP or is this no no okay I mean this should just merge I don't think this is yeah right yeah
why didn't the bot comment on this that's weird let's just make sure that this goes through okay well let's go and we can look at the next uh L2 aliasing ah thank God what is going on in this one
uh looks like it was discussed in earlier meetings and they have made some changes so just requested review all right okay okay this is going in as a draft yeah okay
cc0 Okay so it's okay okay testability sure I mean yeah this looks fine um let's just make sure there's no outstanding comments on here um
okay yeah that looks good and then yeah okay cool now who has changed his requested okay so if they're not passing then
they are passing okay okay all right did did we get into two miscellaneous I think the second one which is a seven two four nine is very small change I guess I don't know why it is stuck it's not getting washed yeah it's missing the uh the bar again
let's see did that other one get uh get merged here yeah it's just waiting on uh cool this one should attempts to find direction okay yeah so this looks like it'll merge now
once everything finishes cool all right so the next one requested by author is 7427 it's a new proposal we said seven four two seven that's right okay oh dear this is a uh messy thing okay so what are there any
other changes in here no okay so yeah so we have that good good the proposal for a tokenized reserve mechanism ready create transition support for actions to the reserve donations to create a reserve similar to real world entity similar the goal is to create a reserve similar to a real world Reserve an entity has as a backup in case regular fund is running low in
the real world an entity will have certain criteria to access Reserve funds in the centralized environment an entity can incorporate stakeholders and hopefully this will help entities this will help us okay that's reasonable definitions owner the creator of the reserves okay yeah we'll get rid of the periods on there for consistency okay
[Music] instructor okay requires 20. um deposit r okay um doesn't see
okay let's see okay we're supposed to deposit proposal mint proposal a draw um okay this is okay rationale the resurface is designed
to be a basically I know I know it's specifications foreign this is an extension of a vault I think
they said four six two six oh four six two six all right together then we can also go leave some comments on the
discussions thread here and we can say uh where was that so that one merged yeah this is the one so you can make a deposit to a proposal
create a new shares make it um this is and let's be open proposal using a mint okay yeah actually I guess they are kind of yeah all right well that's that's that um all right so we can we have one more
requested by author is seven two three one uh this is a proposal for draft all right let's take a look identity aggregated nft all right all right okay it's been corrupted okay cool
foreign good so I think most of the comments been taken care of let's give this a read through um Diego okay relationship experiences okay incentive extends by binding individuals who have teamwork through non-fungible tokens as she's included the body multiple identities that created multiple identity from okay so okay it's your buddy customers give me the metadata and after any verifying the schema hash the contract yeah that's great okay one of the most interesting aspects of what three is bringing individuals
I think that needs a apostrophe there oops and individual's own identification different applications different problems affected individuals strongly own their accounts without relying on centralized Gatekeepers okay this is a solution such as enslr open decisions for theory-based applications are for black beta centralization author authentication of identity due to inherent anonymity the other solution other Solutions such as sbts do we Define sbts anywhere now okay um to non-fungible
nft and I actually think Soul bounds one word I don't know
we're gonna make it one word there we go yeah I think in some of the other proposals it was a word just one word yeah I mean it's one word I think in in World of Warcraft so we're gonna we're gonna use their convention uh okay click the black contract must implement the interface okay zero set up again this file once okay
so that seems good then we can look at this foreign I think these are fine there's no build system files a nice little test file that's that looks good uh what those comments blocking comments or were they yes I can find this full screen and then we will go check the files tab and then we will
this PR thank you all right so the next one here we have is 7441 which is a core and I think gajinder Singh has already added comment but it looks like still it's a like full proposal to be reviewed because the author has also responded in the meantime so is it good to be moved forward uh yeah let's take a look so needs an approval yes I think
a gender is taking care of this this is this comment was from five minutes ago so I think I'll just let them continue reviewing it that makes sense and right okay so there is one uh proposal which I am also very much confused it's PR number 7418 a lot of thing is happening in that it's an ERC I suppose of course okay okay adding that some comments all right let's take a look 7417 am I seven four one seven that's weird uh yeah seven four one eight my bad and
my dad oh okay yeah that's why I said it's like confusing to me is that oh okay yeah that makes sense they um they're inheriting it from an older PR so that's fine so my contract series converge token upon a RC version to another there are multiple token settings of ethereum which and currently the CIP introduce a concept of cross chain cross stated interoperability by creating a service that allows the rc20 tokens to be upgraded to erc223 tokens uh yeah I mean I guess that's fun
um ERC two to three tokens can be converted back to ASU 20 version without restrictions before problem backwards compatibility Okay so um all right
foreign token conversion in the deployment of a contractor who wanted to publicly access and use okay um the main motivation behind the CIP is to formalize the implementation of a service that performs token conversion and provides the address of the contract domain in order to avoid potentially uncertification spread foreign
oh my God foreign contracts
for each okay converter contract must accept deposits of erc20 tokens and send let's see the monitor one two three four okay um foreign foreign
foreign looks fine there's a reference implementation right and then we're going to put a Blocker on that okay so uh we just discussed a PR 7427 uh looks like we are joined by the author and he has some question Jim uh
I just saw the reviews that you guys put so I need to change those but I'm having trouble with the indentation because it's not passing the auto checks the eastbot uh you can so you're talking about the markdown lender yeah yeah you can just ignore that one it's not required okay yeah okay I'll try to fix the the comments that you guys posted awesome thanks so much and uh you know thanks for coming out I appreciate it all right so I suppose we have three more left to be reviewed on draft status um yeah we can take it 7412 or if you
would like you can also take it offline we have already covered everything that was requested by author either in comment or like someone dm'd on the discount okay I mean I don't mind going through this uh on the call but um yeah good so yeah we can take it sure so on domain off chain data retrieval a method to construct multiples with pre-pended verifiable option data okay contracts may require option data that is not already available on chain during execution so so
on change execution a smart contract function could implement this the standard proposed here by reverting with error Oracle data required client supporting the same network recognize this error message relation to the request to query the specified to centralized Oracle Network for sine data and since saved a transaction with the multi-called that prepends the verification of the required off-chain data obviously it will be written unchanging verification to a Smart contract with a subsequent called the read avoiding the error no interesting ethereum scaling roadmap those a series of separate execution contacts for small contract code this makes the ability to read data across multiple chains crucial to the
construction scalable applications also for decentralized energy protocols rely on price data traditional reason is not reasonable to expect Oracle Network which will be able to continually push frustrator from to every layer to a matter of three Network for an arbitrary number of price feeds so 61.70 what is this is a draft okay 670.
thank you okay question here which is deeper similar to another enables reading data from other chains and standard can be generalized for reading any off-chain data for which essentialized Oracle Network including price feeds Wizards for writing and reading cross street data protocol developers would be able to create abstractions for asynchronicity a topic thoroughly explored and other software engineering contacts this will enable
the development of Highly sophisticated protocols that do not suffer from scaling constraints here c3668 introduce these reverse for requiring object data but there are various challenges that standard which I've learned in the rational section below okay contract implemented in this data must revert with the following error whenever off-train data is required okay Oracle query specifies the off-chain data that is being required by the data formats for this parameter are specific to the Oracle ID used okay contract to use this might include
charity contact address just simply this regression okay Oracle contracts like the address of contract which can verify the option data provided in the contractor for the Oracle data required having the contract was implement the following interface foreign similar to how clients are expected to
resolve an RPC endpoint based on a chain ID contract implementing okay okay contradict your contract you must refer
with filing error message if it requires payment to fulfill the Oracle data query fee required fee amount specifies the amount of native gas tokens required to execute the denominator and why this area must be ReSound with the copyright sufficient gas such that the fee amount could be collected by the Oracle contract all right okay
if it requires payment to fulfill the Oracle data query okay um okay so now that must be freshly question data okay yeah so the specification I don't think
says anything about together okay all the simplified version of the clan
hdk this could be demons but the application layer okay this seems more like specification um okay
foreign security considerations yeah I mean that's that's great comment all right so let's take a look at
portable smart contract accounts um in the meantime Sam um I think Jim has one more question about 7427 oh sure uh yes sorry uh you made a comment about uh the two strats that aren't used in public members did I did I miss that I thought uh because they they should be used in in the public members I just didn't should I explicitly mention which members like which Pub functions it should be used then uh so what do you mean so if it doesn't appear in the return or the parameters for a function
um where where else would it would would it be used uh okay because I I was saying within the function it should account for it um but it doesn't return it might emit it might emit uh those values but it should just um account for it within the functions proposal deposit or yeah so um if if those structs appear in the functions or the events then keep the structs otherwise it's kind of up to the contract how they want to implement it if they want to use the struct if they don't want to use the struct like they can do whatever they want so um unless it appears in the events or the functions just don't include it in
the interface okay so should I like in the comments above the public function should I like mention that it should use that strut or uh specifically if it doesn't appear in the return types the return value types or the uh parameters for the function oh then you shouldn't include it yeah so okay all right that was my question all right hopefully that clears it up a little bit yeah a little bit I I'll have to yeah I have to see yeah it's just like we don't want to tell people how to implement the interface we just want to tell people like if you implement this interface you'll be
compatible so like you can make a section later on and say like you know if you want like as a recommendation you could use these kind of structs but don't include it in the interface itself okay but why did you not mention the third The Proposal just because I uh just because I didn't see it okay okay yeah so all three struts okay yeah cool thanks all right thanks all right so our next one is 7405. 7405.
solution working at the proxy layer allowing users to use in my grade there okay um foreign
CIP introduces standardized solution called so we can shorten this up a little bit here um dressed like a portability compatibility let's play smart contract accounts across different providers based on ERC 1967
let me just not involve that the psca system once you're just using migrate their smart contract accounts between different wallets using new randomly generated migration cases provides a similar experience exporting an externally armed account a project key or mnemonic the system ensures security by unplugging signatures and time loss allowing users to verify and cancel migration operations during the time unlock period thereby preventing militia sections it's not intrusive and constant vector yeah okay c4337 standard that kind of structure
related infrastructure and smart contract decades so you don't need to expand them every time you use it up at the top here yeah another infrastructure and SC is type of wine right after the community I would like external extremely owned accounts something closer to find up here as well um [Music] code space needed varying contractual computations across different consequently the lack of portability for SCA has become a significant issue
making it challenging for users to migrate their accounts for two different wallet providers well ERC 6900 proposed to similar module approach for sea accounts comes with higher implementation costs okay uh that we can also say um EOC 6900
6900 are your final yeah your draft is currently aircraft which means this I don't know I cannot advance to your review until yeah see she's another yes 6900 leave the reference in otherwise just remove it
a difficult prevention center for their own implementations or expect their contract systems in size some robust for modular system may not be University football the community can a much more General sea migration standard the goal of this proposes designer Universe SEO migration mechanism that resembles the process of exporting a NOAA account with a private key remote location on the following deck all right and then the diagram is down there okay foreign
totally different okay random operator new I haven't derived immigration the moniker if you corresponding address if it's public keys random operator's address private key post okay the bit 44 so bip needs to be okay one step okay 44 and then
we need to get a current commit okay let's go here go here grab that and I go back over to here foreign cancel account migration
okay see I'm sure the migration operate Mysteries okay to send the migration up with a selector okay it's created using ep191 is that and it requires um okay registration Fitness Behavior it's not accessibility okay
storage lamps okay Okay so you need motivation section all right okay
[Music] foreign okay copyright okay good so we can
comment awesome well thanks for coming out everybody um yeah very much thank you Sam yeah well we'll see you all in two weeks have a good one everyone foreign