EIP Editing Office Hour #16

Transcript

recording in progress welcome to EIP editing office hour meeting 17 thank you authors for joining us and thank you Sam Wilson for joining us and helping out these authors to review these proposals I have shared a link to the agenda in chat um if you would like to go ahead and share your screen the first one for review here is PR number 6808 and the same team has 6809 so we can start from there all right 6808 okay

so this should be pretty easy review here okay did you have any specific questions about this or did you just want me to take another look at it um no not really we fixed all the previous comments which were four or five and yeah okay [Music] um once we are merged or if we do get merged uh today within the draft phase um just to um clarify this is this would make it the first formally tracked stage of the

EIP and development on um outside of The ethereum Magicians yep exactly so it'd become like it gets an EIP number um and I I like as much as any of this process is formalized that's the this is the first step of it yeah okay uh and then uh whenever you guys are ready you can open a pull request to move it to review and that's generally once you're fairly confident there aren't going to be any more substantial changes um and if you're confident now you could do that tomorrow if you want um or or later today um yeah okay marvelous thank you okay yeah so I'll just give this a read

um just one thing to point out and and I I'm trying to do this for everybody who comes to these meetings uh once you go to final there are no changes permitted so make sure you have everything in order before you make the pull request to go into last call okay okay

so as long as everything is like small changes like that I'll just commit them when I'm done reviewing um Congress return false good that's good generally we don't use horizontal rules not a huge issue at all um secure good good okay bindings

see if I'm back perfect good reference implementation good yeah the major changes in these sections were just the removal of some of the

footnotes so it wasn't so repetitive uh for the reader to easily digest the information that is there yeah this this is a much more reasonable list I think you had like 25 or something last time so yeah yeah this is this is good and then you see 20 good good good good yeah so this looks fun and then let me just quickly look through your assets here okay um kpg 20 good good yeah I think that's uh

that's perfect so I will do this and then oh um could you check the allow edits from maintainers um option on the pull request so I can just commit these for you or yeah sure I mean or you can do it yourselves it's it either way it's just um and next up you said was

6809 yep that's the one perfect I'll cue that up and that will most probably have the same changes um they just have just now perfect okay so let's go through that for some reason I'm not logged in on that tab there we go foreign

Ty 721 I think is that the right interface there okay good okay cool so there's that and then

that's okay good good so is the setting in the fork or in the pull request I should be in the pull request itself yeah this just to confirm this is the correct interface um for this heading um yeah it should okay maybe with the dash [Music] all right so I will just leave these

like this and uh we can come back to those in a bit um all right where are we off to next fuja so the next one here is another draft proposal t900 is the um give you the title all right so

Okay so for Server okay um so we are joined by author Jason and Adam here um are there a few if you have any questions related to this beer please feel free um yes so my question is basically just around yeah this sort of review for uh format sort of um content expectations and um yeah like we're still expecting it to stay in the draft stage for a little bit

uh we're working with community members and revising it but uh yeah just sort of a general review of the uh proposal sort of what we like right now okay yeah so um how familiar are you with the EIP process I've sort of tracked uh the guides and um uh sort of walkthroughs on youth magicians and can't hurt us I've tried to follow the best I can um but that's sort of the extent okay yeah that's perfect so um just like the the quick overview this is almost an entirely author driven process so um at each stage we'll expect you to open a pull request to move it to the

next status whenever you're ready um I think a lot of authors get stuck on that and they're waiting for us to like move it into the next stage but that's up to you guys so whenever you think you're ready to go into review Once once it's emergency draft you just open a PR to do that and it's the same for the rest of the statuses as well okay yep sounds good um cool yeah it's sort of a wide reaching proposal so there's been some discussion on uh youth magicians Forum so we're sort of uh expecting to go through a couple rounds of uh drafts before making that move perfect yeah it's the uh what's the common Mark way

of doing that I think it's an exclamation mark three diamond pattern I'm sorry for three interest plugins

good good motivation no uh no rationale mixed up in there and let's reach for seven and you're dependent 4327 perfect um okay okay let's put it

okay do you have this in a block quote for any particular reason or um I think it was just to sort of uh make it easier to like skim past it and stay on the text portion of it but uh we can definitely like adjust it to fit whatever sort of style expectations there are yeah foreign also for I guess it's relatively large

um like interface code blocks like this would you recommend moving it to just be like a linked asset or to keep it in the proposal itself um that's a good question and it's mostly up to to you guys the authors um I it like my personal view is that if if you can't really understand the Eep and you'd be referring to the the asset like often while you're reading that it's probably better to have it in line but um if it's really big or something along those lines and yeah it makes sense to have it as an asset so your call okay okay

yeah I'm just gonna stop repeating myself on those I think you get it yeah and it looks good must okay uh what were these called um I think they're called collabs admonitions that's what they're called

at least in the uh the GitHub vocabulary good good yeah I think um if you just use like a quote and the emoji for a warning or a light bulb that would also work um yeah that looks good good what is this this is a an example so the the example here it's not

actually like part of the spec right like you're not telling anyone to Okay so it's uh yeah it's uh the intention sort of an explanatory component for a uh like coding practice that isn't commonly done um yeah that's generally but without like necessitating as part of the spec because you know you can implement it in non-solidity in many other ways so yeah yeah okay foreign um

okay that seems fine good so if you can provide these as svgs we we have a slight preference for that but if you can't that's totally fine um yeah otherwise I think that's um really well done okay thank you uh yeah we'll go back and make the edits perfect yeah so the next one here we have is for uh last call pull request number is 6672 all right

uh Puja I think it's not that one I'm sorry yeah I'm in a purple request but the EIP number is 6672 but the two request is different number we got it the pull request number is 6949 my bad okay yeah thank you yeah right okay good so we'll have to get this a

read okay so that's fine fine okay so what are the titles here oh this is the redeemable one okay okay

it's okay okay first okay so that looks pretty good let's see the discussions too make sure there's not uh no it seems good

dude all right all right

sorry about the confusion I remember the EIP number instead of P are there no no worries all right so the next one is um PR number is six nine double six and the EAP is double five seven zero moving to last call yeah all right okay good some discussion seems good

okay I mean that seems fun to me cool so so the next one here which was requested

on agenda comment is PR number 6239 I'm not sure the author is present but he paid a mention on the comment that he would like this proposal to be reviewed Maybe sure okay sure it's very commented or

okay oh is this one okay so the issue with this one was that the rdf data wasn't well specified so let's see if that's changed um changes since my last review okay the complete format of an rdf

statement okay can somebody with um a better font open

this Eep and tell me what this character is because mine is not rendering it yeah just want to know if it's a me problem or a problem with the the pull request okay line number 58 ends with the asterisk and Slash oh I don't know it's on me oh you know what it's changing for me for me it's ending

with a triple right six two three nine yes I'm looking at the same proposal but probably in the uh not in the right for me yeah the column two dots I think you can go into preview and see stop shows up as a weird character for me that's weird um some blending coding yeah okay for me here again I'm looking into I think in the right comment it says the

complete format of an rdf statement cologne just the colon it is yeah that's weird characters yeah because they use a colon here and it's a normal colon so I guess they're using a different colon interesting so let's go here and we'll say

[Music] um statement text okay foreign um do we allow W3 standards yet

um we do not I think there's a pull request open for that though okay so what is the recommendation in

that pull request now I guess there isn't a clear recommendation yet oh okay okay

and that's fine okay create our videos okay [Music] okay I already have data okay so I can't approve that yet but

yeah it's good all right where are we off to next so uh next is another requested by one of the authors um the number is a six seven seven four sellable tokens all right yeah

all right 7 12 and 721 to create an ensemble tokens across the strongest foreign

[Music] okay

possible lsgs not be sold teams okay let's event tickets sure okay okay let's see

32 it's okay French for four breakfast signature okay turn to avoid

all right okay foreign ER

okay all right yeah okay this is good

okay good and then okay KCC zero foreign good all right that's uh pretty reasonable

so we have got one last request from comment and the number is six eight six five six eight six five okay which I think they're spam

maybe not but their username is very similar to somebody who was spam so I will actually unhide this yeah it's unclear if he is from the team 6865 that's fine on traditionalization okay discussions two is good required

seven twelve percentage okay good okay

okay and then okay foreign foreign

all right and there we go I have to hop off to get ready for my next meeting um thanks everybody for coming out and uh yeah talk to you in two weeks thank you Sam I think Victor has an announcement to be made uh so Sam thank you so much for joining us today and we'll see everybody in two weeks Victor please go ahead with your announcement yes uh can you hear me yes we can okay yeah hi everyone uh this is Victor and one of the EIP editors and uh some of you might know that we're starting an uh all ERC Dev call a regularly meeting intend to let uh view the community so that ERC authors developers my contract

and the app adapts can kind of help each other meet up and and learn from each other things like um and we want to make and make it easier for people to do Tech and code peer review and to kind of promote their ercs for more adoptions the general idea is that the more that we can learn from each other and then pass the knowledge and information around we will be able to kind of uh Advocate better for open standardization and this is um just like all core devs uh this is a place for developers who are interested in ERC ref uh ERC erc's um so if you're interested uh hop on

this thread and then we'll be pulling the convenience uh the improving the interest in the time slot so if you can kindly uh in this form that would be great uh and then I know that you won't be have access to this uh chat message uh later on I'll also put it in the Discord channel of VIP editors in the ethereum cap herders uh thanks everyone and uh look forward to meet you um Puja thank you very much for the time thank you Victor yeah thank you you are joining us today hope to see you in two weeks have a good one everyone