EIP Editing Office Hour #12

Transcript

thank you everyone for joining us today on EIP editing office I'm meeting 12 up now we have agenda uh and the issue number is two one two um if people on the call has any pull requests that they would like our Editor to take a look please feel free to add them in chat and yeah thanks Sam we have one PR for last call I'm not sure the author is there or not about to from review we have a pull request in order all right so I guess that started okay start with

this last call one here what do we have to do okay how far away is that that's yeah it's good enough um c721 yeah okay so I think this one's pretty decent was there anything still going on in the discussion thread and doesn't look like there's any

yeah perfect so this one's fine to move to last call actually I should make sure that um foreign yeah okay we're good perfect all right the next one is a PR number six four eight nine six four eight nine all right six four eight nine yeah I think this one was pretty good

too yeah I'm not too concerned about the extra lines like that's totally fine good test cases and this is going into review perfect all right and the next one from same water is 6536 perfect so for people on the call generally if you come across any question uh during the review feel free to drop it in the chat or yeah

foreign looks like it's complete and I don't think there's anything going on here there's some discussion um but I think we're just going into review which is fine perfect okay so this is a change to a final EIP five one nine two so you probably have gone a little bit too

far here foreign that's pretty normal um this was going into review okay

clocking clock mode foreign okay foreign

pretty reasonable move that into review all right 5804 negative five and this is probably just moving something back from your C just a whole lot of nothing changes yeah you see removing the link to DNS perfect yeah that looks good foreign

erged just the Bots being buggy I think so we'll leave that one open okay so a question here Sam so uh it looks like this is just uh the bug in bot so closing and opening Mayhem yeah yeah that just makes the Bots rerun so that they uh okay and nothing is required from authors and right shouldn't be um

I saw a sentence question is there something like the authors can do or only like you you can do yeah the author or me can do it yeah oh okay thank you um there's also uh I think you can type something like uh uh rerun and it'll do the same thing it's just I I don't ever remember exactly how to do it and anybody can do that one uh okay thanks no problem yeah okay that looks like it'll work now great so is it eat bot or is it uh any other bot like if someone wants to follow the command um it is workflows

there's etherbot rerun okay okay so any comment that contains that will make the battery run and you can do that on anybody else's PR on your own PRS it doesn't matter okay now for the the long boring ones where you get to watch me read for like 10 minutes I think some of them in the beginning uh are like from sometimes so they should be easier so yeah okay foreign another one of these okay did you voluntarily pay royalties of

chain [Music] okay so there is already one of these um um I think it's this one okay

okay royalty denominator blah blah okay do they actually have the contract in here they do but they are using JavaScript and not salinity for some reason foreign yeah my zoom had also just bugged out a

second ago so I'm not sure if I was missing something okay so wrote the denominator royalty info or c721 I'm gonna have 721 requires they do good okay

okay this needs to be selecting as well okay six four eight nine let's go take a quick look at that six four eight nothing foreign that's a that's weird

we had a conflict because we um we fixed a few typos while this was open oh and then Stephen went and merged Master into it and I think that this might be what uh baseball doesn't like foreign Quest okay well we'll let that Rerun

um okay we saw the specification section here because if we are yeah we are so they have a lot of implementation details down here what is this [Music] this whole section okay

that's fine um yeah I guess I can stay there um Bible um well there was an ore down here what does that do that suppose supports interface so um this seems to have one six five okay okay

um and scrap this and just say okay supports interface people to lose five set price that a token or the denominator so all of these um

yeah it's back tax for code and foreign yeah so this is all maybe not all of it but a lot of it should be in um motivation so yeah so these paragraphs are

zoomed into the okay backwards compatibility fine and foreign

awesome that's good sorry about the the bug eaters there okay so we'll just get this okay when was the last time the checks ran on this that's concerning that that bug is still happening three weeks ago that would explain that okay so hopefully the new the new bot will catch some more of their issues here

foreign [Music] PRS which are like you know proposals from stagnant two truck I think that would be quicker than going into the details of it okay so I think this one is probably just waiting on yeah it's just waiting on this stuff so so uh is there anything that we can advise uh author over there I think all three of them are done by the same author okay yeah so it should

be pretty easy here so we can grab this grab this and then eat one um so EAP title description so title let's get to go here here here okay

that we have to remove simple summary which I can't comment on [Music] okay yeah Spike lines yeah that that's pretty much the only one here everything else should be uh I think pretty self-discreted too so um

simple summary um okay foreign

[Music] shorter here there we go okay a simple summary I can't comment on relative Linker image yeah so that's yeah so it'll just be uh summary I'm gonna remove the ietf

Link at the description and you'll be good to go okay thank you and there are two more in miscellaneous pull requests it seems like that is some bad issue if you can maybe take a look sure I can definitely do that yeah so similar kind of changes here so switch ethereum chain okay let me in the description

okay foreign so what have we got here spelling

changes so it's already been approved yeah yeah that's odd so what's it looking for um okay foreign so we've got the validator failing here

yeah okay but this is a non-author that's doing it right yeah but the author has already approved it yeah yeah no the the problem is like um yeah so if this is just a um spelling change like if that's the only change I'm just gonna override the bot yeah because there's no point in making a non-author go through and fix all these things that's right okay

all right and then we have this one here so this is also waiting on validate or changes so this is for a draft yes this is just waiting on them fixing I'm mostly just this which I think it is just that actually you know what I'm just gonna

foreign just going to do that for them so it wasn't space it was a space issue yeah they had an extra space in the um in the Preamble yes that should be yeah that's enough to get it to pass so this should merge on its own now foreign the life of an EAP editor just shepherding the Bots for

hours a day yeah instead of EAP authors yeah basically the uh the pods are okay I mean they do their jobs most of the time no they have been very very hack in 2020 okay okay and then there was a comment uh

this is 6.5 the and that's this one 6409 um I will say here [Music] okay

okay and then on this discussions to your thread [Music] a whole bunch of stuff here soon good morning which turn it back over here

P2P s code governance incentives all right [Music] okay interface really conscious extra funds based on an account taking action down okay so this is this is an interesting one so it's near C ouch

okay foreign driver incentive or interpreted as the traditional assets from foreign

[Music] specification so you have no quantity because in reference implementation yeah foreign

good hey this rationale is actually rational that's that's excellent and 420 extra server is good good General ethical issues okay okay yeah natural limitation details yeah so foreign

[Music] foreign [Music] foreign foreign

decent good okay address format and metadata so I think this is just a yeah close and reopen I guess I just need a review as well

okay wait why is one one more yeah this shouldn't um I don't know why this requires a reviewer that's odd I'll uh give me one sec I'm just going to send a message to Panda pep about that okay foreign

yeah that's an easy one to fix Where is the edgware foreign any questions about the EIP process in

general while we're waiting for this or um I think um new editor he has just dropped off for another meeting but uh I I have suggested him to follow the recording from here on and I think so far it looks great and if you have any further question maybe we can take it up in the next meeting sounds good but we have covered quite a lot of proposals today yeah yeah screen going through them quickly

most of them are merged and that and that law is not going back to the author for doing further changes so yeah it's good yeah yeah oh that reminds me did you um uh get a chance to follow up on the statistics about the number of comments and how long uh PR stay open for uh not yet I am working on that yeah that's a work in progress I'm looking for a good UI to maybe have those um displayed there foreign not exactly a huge priority or anything I was just curious yes that's a good point we will try to track that yes

yeah otherwise I'll just I'll make a Excel spreadsheet or something and go through a bike um I mean if I even need to we'll see okay permission token shade what have people been talking about here so Panda has an approval on this so why didn't this merge because no idea

close and reopen foreign okay

okay foreign

yeah I mean that yeah okay so why didn't this merge so [Music] they are an author so this should have just merged weird okay yeah some of them here are a step

because I bought you know maybe today you provided a very good piece of advice for EIP authors like they can also rerun the bot in case it is not merging automatically without throwing any error it is just stuck yeah if it gets stuck for some reason foreign

foreign people using JavaScript lately for uh solidity code blocks weird foreign foreign

the specification okay yeah I mean that seems okay good only three more to go for the day yeah

um yeah I guess I could try to get through these okay local tokens that needs to be assigned okay so foreign [Music] okay good so 16. blockable tokens I think we already have

something called lockable tokens not that it really matters save local non-fungible is that to these are lockable fungible okay so this should be extension for tokens to be locked for okay it's fine that's fine

[Music] yeah this needs to be so foreign okay

there are a number of interval tokens which are interested thanks for coming out uh their children [Music] okay good okay foreign

foreign cools that's very reasonable okay single contract multi-deletal foreign

um foreign [Music] payable all right

okay and let's see how big this is based on the title it seems like it's going to be a big one yeah I'm not going to start this today I think we have to add pretty much everything but unless it for today so this can be taken offline not a problem thank you so much yeah thanks for hosting Puja Take Care thank you everyone have a good one