EIP Editing Office Hour #11

Transcript

welcome everyone thank you for joining EIP editing office our meeting 11. we have quite a few pull requests added in the agenda for discussion today um Sam if you would like to screen share we can probably start with the first item listed here that is uh oh I'm so sorry so we do have author for proposal 6381 pull request number is 6381 that is for the draft that's correct thank you thank you yeah

all right hey thanks for coming out do you have any specific questions for this or is it uh you just want somebody to look at it no specific questions um so just give this a quick read here okay foreign it is short which is good um I I might add a little bit about like how like our let's see so they are just

okay so the emotes aren't actually stored as another nft they're they're just a property interesting okay [Music] um okay that seems very reasonable um this I think has the wrong EIP number or is that the right EIP number no no that's uh another VIP we worked on we'll fix thanks okay uh let's see uh triple tokens extends deep 721 um so you could make it a bit more General if you also supported

1155 it's not a requirement obviously but it might be nice to think about because a lot of newer nfts are using that standard yes I I don't think if there's any issue supporting it but it's just not required uh but so how should we approach this like where would you should so you could say something like the emotive Ascension extension for non-fungible tokens extends uh standard non-fungible token contracts like your eip721 EIP 1155 by allowing nfts to be demoted at um and then it would they have different interfaces or would would you have the

same interface for them I think you'd probably need different interfaces yeah so you just make two interfaces for them and yeah yeah we probably need a an extra parameter there yeah there's two separate Apes you could just do 721 whatever you like it's not not a requirement okay um okay it's good um okay just

it's four so it doesn't actually enforce it to be a valid Unicode character or does it just let it be any four bytes no it would be any uh I mean you could you could have if this opens the possibility for uh some implementation to have custom uh emotes but of course only them would understand them but we wanted to leave that door open that makes sense okay um and then really small nitpick I think uh 721 uses the like property of um naming convention so it's like owner

of uh whatever so instead of get remote count you might want to do a moat count of um again really yeah well I could I could um okay good you're you're rationale okay The Impressions committed yep that looks good backwards compatibility yep tests look good um so your interface name here doesn't match the one used in the reference oh yeah yeah we will fix that thanks oh no problem that's what I'm here for um

okay I am multiple good okay and then do you have okay that looks good okay um so you should so yeah we've had some issues with this

on the other earpiece okay because I mean we need this one's small I'm reasonably okay with keeping it yeah but we also need the package in order to be able to run the tests yeah yeah we try to keep it minimal like this is really no no this is fine I'm I'm mostly worried about packagelock.json this one's this one's okay so if you want to keep it go for it all right no that's great um oh once it's all done I'll take another look at it and it should be good to merge as a draft awesome thanks Tom no no problem next one should be more fun no not another Soul bound token this is

what you're talking about yeah oh we have a typo there salt problems yeah okay so before before you go on it well it should be there but uh we are aware that there are a few proposals two of them even in final but they are really not minimalistic because they include events in what we explain here why we consider that limiting for many implementations all right yeah you've got sold bound a few times here yeah I am okay

specifications foreign so this is just tied like literally to 721 I guess or or whatever token standard you want and then it just says yes if it's so bound and no if it's not that is that is definitely minimal yeah yeah it's as simple as that you know it allows for a wide range of of implementations okay so okay

so I guess one thing I'd like to see answered and this is you know not require this is just something I'd be interested in seeing is why have the is soul bound a method at all um like why so why do you even need the standard if all you're doing is making the transfer functions for 721 fail like can't you just tell if it's Soul Bound by trying to transfer it thank you yeah that would be annoying and spend guys but we cannot change sorry oh yeah I guess you can't do it I'll trade if you want to know in the con in the contract yeah I guess that makes sense yeah but we will add that to the Russian rally probably the only comment I'm gonna have

to make on here um yeah I mean seems seems fine to me very simple nice so um location specifications ah so uh you don't actually say in here um I guess you say it in the comments here yeah this folks will try to do the transfer of the talk of much revert execution yeah okay yeah okay it's there so yeah this this looks good I'll approve it just make sure you fix that one

um immotable in the backwards compatibility sections okay awesome thanks for your time this is really soon all right so let's go back over here unless we have another author on here I didn't I haven't checked chat yet yeah right so uh there are first two proposals they have been requested uh by different authors but unfortunately they are not in the call but yeah we can go through them okay which which ones are those is that uh so the one on the screen yeah okay so what are we looking at here okay so it's just pulling it out of

stagnant that's fine um this is changing the Status from what the previous one was let's find out it's actually so it was in Draft before so we're coming out of draft and going into review so let's give this a read okay the folks here notice is an API for directories sometimes oh it's this one

okay so what traditional file system standard provides basic functionality to rewrite binary objects of any size okay it seems good fine think these need to be indented one more okay

we're expensive to the new K function rate complete fall back okay okay I think that's otherwise fine um all right so that's an easy one and then 61.47 what are we doing here so we're moving to review

this is not expanding come on fine start of nft SBT and extension of 721 okay foreign okay okay some spaces that's fine looks good

looks good gaming okay yeah it seems reasonable all right

then we have two from stagnant yeah all right actually one thing I need to do on this one before yeah if you have any questions feel free to ask by the way like this is supposed to be more of a I don't want to just sit here like scrolling through text for an hour any kind of discussion we can have is good foreign all right so do we have a no we don't okay so

just gonna grab a reviewer here and we'll add them to this big list and then we'll go so reviewer allocation is it's still done by you or uh the proposal can also propose a reviewer oh the proposer should absolutely propose their own reviewers I just picked somebody randomly from a list I have in a in a hack empty it seems seems to work I think um I don't know maybe about a quarter of the time uh the volunteer actually replies and gives some useful feedback so um I I think that's doing pretty well so far yeah that's good yeah I mean if you're getting responses that's what matters

all right so put this here and who are we gonna so this is this is an nft related one we don't have a lot of nft reviewers if anybody wants to like help peer review nft stuff there's no like you know expectation of doing any work but if you want to let me know I'll put you on the list [Music] um I'll maybe check with some of the authors so we have on people need because we do have some nft related proposals and in that Series so we can check with them that'd be great yeah

all right so out of the four people we have we're gonna reuse a thunder deliverer because we reviewed one of their eip's earlier so this is the price you have to pay 61.47 61 47. 1 47. username and username and we update this what's today's date

it's February 7th all right all right cool so I'm gonna close that Eclipse that actually I don't think I could close that yeah okay just hasn't updated on here I don't understand that like we have been trying okay yeah it just moved a few days ago to start mint yeah yeah so what was in the

previous so when it moved to stagnant it was in review so totally fine just to approve this okay something else

people Look Down Under the validator passes okay so that looks good 1828 it would be good to see 13 28 moving towards final right yeah I mean if it's in use they might as well yeah all right so what we got going on here so okay so this one's just uh waiting yeah this is a yeah a good proposal again I don't know why it's

going against they should also move forward because now we have a lot of implementation even KGC ceremony also has sign in with ethereum yeah exactly like standard to review fine so wait what is wait 1328 is that literally the one I was just looking at am I yes what does this depend on 1328 specification I don't actually know why maybe connecting for uh with a wallet 14 28.

that's weird um yes actually can I just edit this file I can that'll make this much easier it's shouldn't it provide different interface

for connection like uh maybe metamask wallet connect and yeah I mean I don't think signing with ethereum makes any statements about that right that I don't think they yeah I get it so I think that's the only thing I need to change on here that we could just wait for all of this to finish oh yeah that happens all the time

uh Jen it's it's somewhat annoying okay what did I break now okay I didn't we're just waiting on six three four yeah so just I don't know okay let's release that and then there's one

about ens somewhere in here to do foreign foreign

six three four is probably stagnant stagnant foreign so back to six four five four for a

second five four all right what do we got major changes cleared the review yeah okay what type of typo do I have this one perfect six four five four good good seems good to me thank you oh thank you yeah um sorry this process is so so so slow

sometimes no problem with Allah okay I got it that's a lot of proposals so we're updating to review status see just make sure everything is why is this button not working today it's like my favorite button in GitHub okay so yeah I'm gonna increase this compromise this is okay

oh I remember this one from a while ago this is like um an optional way to protect people from with withdrawing yeah yeah we recently had a chat with the author and I suggested that this proposal seems to be a good fit for review not in draft because this has already been implemented by some of the consensus care client and some are waiting that they would be implementing after the upgrade because it talks about a manual list created on GitHub so yeah okay yeah so it looks like they have all the required sections they're just moving to review so we're going to approve it and then from the big list of review well actually let's see this one probably has enough review

if it's a semi-core thing let's see so there is this a little bit of confusion of it being in core and interface because more of the consensus layer are not going into core they chose to move their interface so it becomes optional and not because any consensus changes yeah that makes sense I mean let's see do we have anybody who

can review this we have execution layer somebody who hasn't been pinged before no I think we're I think we're good for this it's probably has enough eyes on it so we'll just leave that four four seven so six three seven six I needed this merge does this just need to rerun it probably just needs to rerun so this is six one eight eight

six one eight eight foreign stuff yeah okay it's fine this is six one eight eight six one eight nine yeah okay so same deal so we'll just

approve this one now so that should get everything merged eventually all right so what's wrong with this one so this requires author approval so that has nothing to do with me I mean I guess I can put the label on it there 6188 I think we already did that one yep

um Sam uh about the last one six three five nine it looks like the changes are done by the uh proposal right and uh what is missing here do we need approval from Pavel uh they're adding themselves so they need to be approved by one of the old authors first before they'll they'll count okay so it looks like a gumbo had reviewed it two weeks ago yes but uh explicit yeah yeah yeah so it got changed um so it needs new approval okay I'll inform the team yeah I can put a comment on here oh yeah

that would be great foreign all right

all right yeah like this needs to be done in a separate PR this can't be uh emerged until that's done and okay another transaction token requires

20. so this one the Englishman transaction fees attracted to nothing from the answers the answer is three token transfer amount that I think needs an s key print centers okay is this core or okay motivation okay

um yeah that's right that should be a returns tactical summary say something

I forgot to meet myself hi I'm back welcome back so just show the comments okay let's get this out of the way come on my computer is literally falling apart today there yeah it looks great thanks amazing thank you see you in two weeks bye

okay I just thought the existing issues with okay conservative personal limit the functionality or something okay okay execution foreign foreign

foreign foreign

okay yeah this is like very opaque to somebody who's not deep into meta transactions um because I I'm sure okay sounds purple

additional options for transactions should be provided to claim the statement Rewards foreign so this needs to be a lowercase solidity uh request

domain separator wait domain separator so that means this needs to require that 712. foreign okay then this seems to be a lowercase

again okay so why what are these things so is it count used publicly anywhere can't striped account other accounts foreign okay

okay you know it seems to be a lot of case this is the specification section so are we in the yeah we are so yeah you're gonna be able to foreign

okay it's a long one yeah yeah it's a long one with a lot of comments so this is okay umatic motivation not rational the rational section okay

foreign so I've got some tests here good we have some foreign stuff and some fixtures we'll just trust minimized proxy 1867 that doesn't seem like it's relevant for

this maybe it is I don't know call by signature accounts can't request draft actually wait turn token Okay so what is this oh this is from a different EIP

what all right so there's some comments on this one eventually yeah maybe we can take the last two they are both are interdependent okay six zero three zero and six zero three one yeah 49.38 so is there one okay that's what we need to find here

actually just check eat 49.38 are you in review you're on draft oh yeah the other day we discovered there was there were three not two okay so why this is the same one yeah so why isn't 49 38 not moving to review yeah that is 67 right 867 okay so that has to go before eat 68.

yeah yeah that makes sense to me um they can either remove the requirement on it but yeah it's it just needs to move that to review okay we will think Marius for this I mean I can do it too like it's not exactly a big p like a big change but uh don't have to approve it anyways so yeah I guess ping them about it and I guess shoot me a link when they put it up but I can I can take care of it okay all right what's going on in this one okay

foreign okay

I don't think address is supposed to be capitalized there's plus a few priorities okay good six one forty five six one forty five the standardized social media networks empty marketplaces and other websites just royalties associated with really interesting things um okay

foreign Ty so where is this external link that they're having trouble with there aren't any so it seems to be the problem here non-relative blank or image oh it needs

to be okay please okay

okay okay compatibility um foreign thank you

okay good good uh wait what rationale no that's right yeah there's just nothing in the specification section um and specification is above rational what is going on here um changes integration keep validator okay those are the only two errors that can't write shaft motivation specification rationale

nice that is correct it's just they don't have anything in their specification section foreign all right and that is all the time I have for today so thank you for coming out everybody and we'll see you in two weeks thank you Sam thank you