EIP Editing Office Hour #109 (EIP + ERC)

Transcript

[music] Heat. Heat. [music] >> [music] >> Thank you.

Jesus. Thank you. >> Heat up here.

>> Heat up here. Heat. Heat. [music] >> Heat. Heat.

>> Heat. Heat. [music] Heat. Heat. >> Super

interesting thing. Very well. Thank you, Akash. Welcome to EIP editing office hour meeting number 109. This is added on Ethereum/PM GitHub repository and the issue number is 2180. On agenda we have a bunch of uh open PRs which are ACD related meaning they are either uh related to Glamsterdam or Hegota upgrades followed by a few miscellaneous items which I hope we can go through it quickly and uh then we have PRs to move status.

We are joined by couple of authors. uh we will get there but maybe we can quickly go through ACD related to begin with. Uh today we are joined by editor Yohham Braher. Welcome Yoham. >> Hi. >> All right. So yeah I think the first one uh seems to be real quick. [music] >> We can start with the first ACD related PR 11869. >> Yes. Yes. The thing is that I do not think this is quick. The problem is that this is a CI error and [music] the CI will error because it's an URL into the uh into the uh the EIP which is not

[music] yet allowed. Um and we have to allow this. So we have like this EIP what is it again? EIP that's somewhere >> 5757. >> Exactly. Exactly. And then [music] we have this this this this where is it? Um we have where is it references that's somewhere? Yes this one. Yes. So it's this uh decision point. Um, [music] and well, we currently cannot decide this [music] yet because I think

that Sam has to actually um formalize these decisions. Uh, and also not all the editors have voted on this yet. [music] So, we can't do that. Also, Sam is saying on Discord like we are supposed to wait for all the editors to chime in. Uh so yeah this is uh this is a blocker for this PR uh I think the office are maybe slightly irritated [music] and frustrated about this which I can uh uh imagine uh but yeah sadly we cannot merge this now um let's see if we can maybe point them to how to fix this because let's see

where is Yeah, I I I can also cannot suggest to Yeah, I I could suggest Okay, you can No, no, that's that's not a good idea. No, it's uh it's it's sadly it's blocked by um by by this decision. [music] So, yeah, it would be nice if uh the last entity can also vote on this, >> right? Uh thank you for explaining this. This is very helpful. I am hoping that uh the author is aware of this open CFI and uh what we can do is go ahead and ping the fifth author uh fifth editor to add [music] his input. We really do not have to wait till uh 27th of August. We

can try to get it done sooner rather than later. So yeah, I'll make a note of it. >> Yes, exactly. [music] Okay. Okay. Yeah. Thanks. Thanks, Puja. Yeah. Yeah. We've also pinged this person [music] on Discord. Um so yeah um I think it will come to to to to this person's attention that this is somewhat uh urgent because I would not think that there is any reason not to uh to allow this but well we never know of course >> right >> yes >> yeah and I think the fifth uh editor uh he is ERC only editor so I'm not sure if uh we really need to wait for his uh like [music] consensus here but uh

because it has been a process that we want all editors and the addition of any new link should be unanimous so we can just check with the editor. >> I see. I see. Um yeah I mean of course EIP1 is also uh of course [music] setting the rules for EIP uh sorry for ERC's. So adding an allowed URL to from EIS also directly allows them from uh to ERC's. So >> from from that P perspective they should also have like a a sales.

>> Yeah. >> Yeah. Agreed. All right we can move on to the next few PRs. I know some of the peers here are waiting for author's approval which we are working on and hopefully we'll be getting before the next ACD but um I understand that there that is not a blocker and editor can still go ahead and mark approval if the changes seems appropriate >> right um I'm not sure actually because I'm going to push back on that uh I'm not sure if I would be comfortable to merge things without uh the office approval Um because I think this >> it will not be merged. It will not be merged. It just

>> Oh, right. Sorry. Sorry. I see what you mean. Yeah. >> So the thing with this uh one, this is one of my earpiece. This needs this also has a CI error and we need to to remove this comment >> which I have an PR open for which I have also mentioned here. So this uh asked me but I wanted to to check with Felix what he um he thinks about this >> right but I'm wondering if uh that is like um a change that needs to go with the review ch review status change because in the earlier PR it is just review status it just can be rebased and the PR can be added separately the draft PR

>> yeah that's actually good points yeah I can actually just remove this command That's actually that's right. Yeah, this is like not so critical that we need to need to add this. >> So, I will do that. Not sure if you can see all my screens, but let me quickly edit this in here. This is 75. Let's add this.

Okay. All right. So, [music] let's get this one matched. >> [snorts] >> It's right. What's this? Okay. Yes. This. And then I can also [music] puff this one. All right. This should get merged after this one is [music] is merged. So that's nice.

Okay. Let's see. >> Right. This one should also be fine. What is it? all right. Okay. >> Yeah, we want all the EAPs to be moved in review because that will unlock the meta EAP to be moved to the review status. So the other specreated changes can be taken care of with a separate pull request. It doesn't have to be like you know blocking the review status.

>> I see. I see. I will also put this one. So if an offer also approves it then uh it will get >> Yes, [music] that's right. Yep. >> So that's nice. Okay. Right. We can also merge this one. Okay, great. Great. Great. Oh, this one also. Wow, [music] this is a nice office hour, I would say. [laughter] >> That's why I wanted to go through all the easy one first. And I know there is draft proposals and some miscellaneous which will take more time.

>> Yeah. I did I closed this one because seems like Maria made another change um 5 days ago >> because this has been waiting for over a month. So she made change and I have to close it. It's okay. >> Okay. And it's [music] 2780. Is it in in the view? >> It is in review status now. >> Ah I see. So we can >> that's why CI was failing because there was no change. >> Ah exactly. All right. I think I saw this one today like okay this has no change. Um okay [music] let's also yes let's also approve this one okay very well that means that almost everything for glamdom is now merged so well will

[music] be merged so that's >> yeah we are waiting for couple of authors and then all the PR all the EIPs can be moved to yeah review status so for this first one of CI I think Sam already had a review and we are joined by cyber centry I hope you're looking into miscellaneous. >> Yes. >> Okay. Yeah. So, we are joined by Cyber Centry who made this uh issue and Sam has worked on to solution with a PR and it requires editor's [music] approval. So, please take a look at it. >> I see. So, um All right. Let's What is this issue?

Uh-huh. Right. >> Just to give a perspective, this bot is active on EIP repo but not on ERC repo. So that's what we are trying to solve >> I see. I see. I see. Right. Right. [music] Why this work? Okay. Great. All right. Let's merge this. Yeah. Okay. The only thing is that we also want to merge this into that piece and let don't okay. Okay. Yeah, let's merge this one.

All right. Okay. All right. This is this is the issue. Yeah. Okay. I see. So, we can also directly close this one. Does it auto close this? No, it doesn't. This should work.

This should also work. Yeah. Okay. Great. Let's see. What's this? This. All right, that's okay. All right. This is okay.

Where is that? All right. It's this one. I see. I don't want to. An interface proposal.

It's not that one. This one. Let's see. Green. Yeah, I mean these these [music]

definitions if you look at them they look context standards, [music] language level standards, they overlap somewhat. Okay. Where is it? Where's the Right. Okay. What's the [music]

definition? application level standards and conventions including context [music] such as token standards application level language level standards right oh we need to edit this because this is not uh the right EP reference [music] here >> I I think I made that change but uh sometimes it requires on both repos to be showing here. I remember making a PR to remove this.

>> Interesting. [laughter] >> I'll go back and check on it. There are quite a few EIPs which are not like right to be there in EIP1 right now. >> Interesting. >> I mean, yeah, we need to find that. Yeah,

this ear that's a new fell format. Yeah. Yeah. Yeah. Okay, that's why we of course keep so many tasks. So this Totally

out. Get the code.

Okay. Interesting. Interesting. So for this one it requires two editors approval. One has already added. We are looking for one more. Cool. Okay. Oh, great. I was I think I was the person like pushing like super hard for this one. [music] >> So, Oh, wait. Is And why is the my review not being okay this Ah, right. Okay. I dismissed my review and never reapproved it. Okay, let's let's do that now. Great. And that also then means that I think we should >> do the ERC repo.

Uh I'm sorry I have not looked if he has created an ERC repo PR for that one. >> Yeah I I'm actually not sure. May maybe you don't have you don't need that at the because these [music] repositories get like merged. Let's actually check quickly because that would mean that changes to EV and one.

Yeah, it it has also to land on on this one. So that we also have like these URLs here. So yeah, let's see. Okay, let me quickly open it. this one. Um okay before we move forward

I would want you to bring it bring back to some of the PRs that you already have reviewed but they are not merged. So uh ERC PR 916 it seems to be done but not merged yet. >> Oh well one second one. Let me sure finish it up. [music] Okay, let's see. Has it been merged? Yes, this one is merged. Okay, which one uh is it?

Which one did you reference to Puja? I'm sorry. I was on mute. Uh, so yeah, the top one. 1 1233. >> Uh, one, [music] two, >> 033. Review first one. >> I'll write this one. Yes. >> Okay. All right. And what? [music] Why is this doing this? Huh? Okay. Why? Why? Why it is? Oh, right.

Yes. Yes. Yes. It's [music] this one. And it now needs this one which is open for some reason. Why? >> Yeah. [music] >> All of them are showing some error. Okay. What? Let's see what's going some weird weird dash. I don't know.

Let's see. H. Okay. Right. I see. Oh, okay. Yeah, I I caused this problem. Oops. I removed like a footnote which was actually [music] a URL to this uh uh this EIP. So, if I do this Well, it's short.

>> Yeah. Okay. Great. >> So, the next one two one 12 034 that is also not merged. This one, right? >> Okay, let's see. Okay, interesting. Why Why is it flagging this now? Ah, wait. Maybe maybe this EIP has been updated [music] since um Huh. Okay. Interesting.

>> In fact, we have received approval for 8159 as well. >> Yeah. I mean, if you would be open to merge it independent uh other PR other open PR, >> right? Which [music] PR is this? >> So 1236 is the PR for 8159. 1236. >> Right. Interesting.

Uhhuh. [laughter] >> So So yeah. So this is blog by 7975 which you already have approved. >> Yes. So so this is this is my one, right? >> Yes. [music] Okay. Okay. That's that's okay. That that that should be handled somewhat soon. When where is this one? This one is Yeah. Okay. So, this will take like 10 minutes and then this should get merged.

This one is approved. Okay. That that should get merged and then we can also merge [music] this one when we Okay. >> All right. >> Cool. Uh so maybe we can get back to each one of them in a minute. We are also joined by an author. Um and the PR number for his proposal is 1 1909 on ERC repo. >> 1 1909. >> That's right. Yeah. And author is Arma.

Hey Let's see. This is already Good.

No, I will directly comment on the on the PR. So you can directly take [music] a look how um uh or well well change change the things I'm suggesting. >> Thanks Uh, let's see.

Let me see. All right, I have some minor points but

um well I mean this looks good. So if you address the minor points then we can uh then we can merge it. Let's see. This has been merged this much now this one. Um, let's see. I [music] think Yeah, I think I will just continue on the list because I don't see any other people in the chat, >> right?

>> Yeah. Um, maybe we will uh take a look async on the PRs which are like merged today. If they are not merged then I will ping it ping it in the editors discord. >> And I think that's pretty much time. We have got it for today. >> Yes. Yes. Yes. Let me quickly rerun this one because why is it not doing this? No, I don't know. >> Okay. So now 7975 is merged. So I think it will clear path for others.

>> Yes. I mean this one should not also pass but it's directly rejects. Oh wait okay I will do no this is weird but I didn't is it doing some are not allowed in statue [music] me. Okay, it's okay.

>> Oh, I I think we need to just remove that comments icon there. Then it might help or and you can make like add it with another PR. >> Yeah, but uh I mean we we just merge this and this actually removes this this uh this comment, >> right? Yeah. Yeah, it should be merged. >> Would it require me to rebase that? Yes, I I [music] think if you do that then it will also work. >> Okay. Perfect. I will go ahead and do that. If anything goes wrong, I'll ping you in the editor's channel and we can take it from there.

>> Very well. Thank you everyone for joining. Thank you Johan for taking out time and helping us move these PRs merged and >> we hope to see everyone on the next call next Tuesday at 1600 UTC. Thank you everyone. >> Thank you guys. Good night. >> What's up?

>> Heat. Heat [music] up here. [music] >> Super [music]