EIP Editing Office Hour #102 (EIP + ERC)

Transcript

[music] [music] What happened?

>> [music] >> Thank you. >> Heat. Heat.

>> Heat [music] up here. [music] Heat. >> recording in progress.

>> Welcome to EIP editing office hour meeting number 102. This is added uh on Ethereum/PM GitHub repository with issue number 2123 on agenda. We have some items from all core dev meeting agenda as it was decided in one of the EIP meetings that we should probably prioritize PRs which are waiting for discussion in the allcore dev meetings. So that is the first section followed by the usual list of PRs which we collect from EIP/ERC repositories. Uh we are joined by editor Sam Wilson and Sam before you start looking into uh all these PRs we are joined by a wouldbe

author and he has some question specifically I believe he also looked into ETH magicians forum earlier and want to share some uh some questions with you. >> Sure. >> Oh I'm I'm happy to wait my turn if if other people were in line. I don't I don't want to >> Oh, if you're here, we should we should talk first. >> Okay, >> that's what the meeting is for. >> Okay, so here's I have a weird EIP. Um, specifically, it's it's an adjustment to a wellestablished EIP. And so, over in the Solidity world, [music] they want to add type hashes as like a language feature, but they can't do that because 712 is not well specified. So

EIP712 has like a schema and it has like rules for the schema, but it's just not right. Like it's missing some things. So I you guys see EIPs all the time. I was curious what you think the right process would be for uh trying to create a new EIP that locks down all the ambiguities of EIP 712. >> I think that's a great idea. Yeah, you just have another one. Yeah. But do I do I start with a uh like a post on Ethereum magicians and kind of say like here's what I think or >> so I I I think [music] personally as somebody who's read E712

a lot I think it's pretty well understood that it's it's a little messy and underspecified. Um so I think you can skip right to um writing up an improved version of it. Um I don't think anybody's going to object to that. Okay, then I guess I'll just go put it on Ethereum Magicians. Uh to answer Luke's question about what it's missing, like there's the type schema allows for things like recursive types, um referential types, like like it's just not specified what you do with that kind of type hash. And so like there's further questions then about like okay, so if you have this schema, what do you do in solidity? Like what is an enum?

What is a type alias? What are these supposed to be? like actually written down to. So there's kind of two sides to this which is one tightening up the type hash scheme and then two solidity making opinions about how to translate its type system into the 712 schema. So there's just work to do. >> Very well. [music] Um in that case maybe we can get started with the uh proposals which are added for from ACD agenda and then we have some authors join we can take one by [music] one.

>> Sounds good. then let's go see.

Okay. So, don't know why people have such a hard time with the uh the syntax for this. Maybe because it's a horrible syntax. So, we get rid of that and then go. Oops. Take a look at one. Go down under this one here. So, it's four spaces in CSLJS.

One, two, three, four. Yep, that's right. So, let's see why you're going to complain about this. Sounds good.

Okay. So, there's a missing comma on that one. transl. Um, okay. So, why does this not have a DOI?

[sighs and gasps] That's unfortunate. I'm not exactly sure what we can do with

that. So, just leave Oh, this one either. That's annoying. So that one is a DOI. So that one will

work. Um This last one also doesn't. That's so

annoying. Um, So that get rid of that. Hopefully

that's more valid. Jason. Um, do that and then we will leave the comments [snorts] that need to be left. Okay, back here. Good. So, privacy

pressing requirement for Ethereum is Ethereum's economic and security powerhouse at the time of the CIP contract looks locks more than taking close public. There we go. And then we wanted to move

on to 117 11744. >> Yeah. And that's also for from ACD meeting. But I thought that let's address questions of authors of their RNA. this username then email address.

Okay, these are all fairly minor changes. It's fine. the uh requirement is stated elsewhere.

>> Yeah. Yeah. It's I I I get it. It's just about not having the uppercase here then. >> But it is a must. >> Yep. Am I am I supposed to not put put it in uppercase even though >> yeah basically if it's a an instruction to implementers it should be in the specification section and then [music] discuss yeah exactly >> am I not supposed to repeat it there >> uh basically yeah yeah >> that that simply makes it harder to understand >> I mean otherwise you're just putting the same require environment in two places.

>> Can we merge the thing and deal with this later or can you just change it now? Whatever. >> Yeah, I'm not I'm not super picky about it. This is still a >> Yeah, we are really down to knits. >> Yeah. No, I I not going to hold up the merge on this. >> Okay. I'm just noting down all the >> that is at this point the backwards compatibility I'm discussing the implications of the requirements >> that's the word >> on backwards compatibility um so it would be strange to not capitalize something that is a requirement

but >> oh yeah like I said I'm not going to not merge it. But uh yeah, um that's all fine. Okay. Okay.

And then so this is going to sound stupid, but could I just get you to email me from your email address? Um >> um could you send me an email? I'll reply to it.

>> I don't have your address handy. Mine is sitting right there. >> Not a problem. >> I'm currently waiting through 351 unread emails. Yeah, >> I do a I do a search for unsubscribe. It's hopeless. It is absolutely hopeless. But that definitely is my email.

>> Oh, I I believe you. Yeah. >> Yeah. Has been for I don't know how many years and I hope I never lose it. >> It's a good email address. One morning I woke up and from time to time I checked and there it was. Okay. So I'll leave that open.

And >> so next we are joined by um Lei for PR number 1797 on ERC repo >> 1797. >> That's right. I I don't know if the rules changed, but for a while it was only complaining if if list items were inconsistent. It didn't care if it was an underscore or a star. They just had to be consistent. And then at some point it started demanding that they all be stars.

So a lot of the changes [music] were just turning >> switching that around. Yeah. >> Yeah. because they were all consistently under scores and it hadn't complained and then it started to complain. Um, >> yeah, I I don't touch that bot at all. I have no idea why it would change. >> Well, the I think the stars are more standard and the underscores are a extension. [music] I don't know. There is no standard for mark markdown. common mark.

>> We had a much we had much better tools in the 70s. I don't even want to get started on how this actually renders on other site. >> Yeah, it's uh it's a mess.

I can't I can't I can't start a breakout with just a link to a blob. >> You can't start a what with just a link to a blob. >> I can't start a breakout with just a link to a blob. Now pe people are going to look at the EIP number and they're going to go to the EIP page and they're going to find an EAP which by now is [music] months out of date from what I'm actually proposing. >> Yeah.

Yeah. Then we have the author on the call in case there are any questions for him. Yes, I'm checking that one. It's a It's

a fair shout. Um, I've obviously mistakenly left that one in from the process we went through on drafts where we were taking out the E Foundation RFP 16, >> which is what this one's based on. But yeah, I'll I'll pull that one. Yeah, this is fine. Cool.

Next on the call we have author for ERC 82 62 and the PR number is 1747. >> Hey everyone, happy to field any questions. >> All right. So fantastic Mr. box. >> That's what life feels like.

>> That's funny. okay. So, press [music] verification and track compliance. I'm assume it's like basis points or

thing. I'm assuming it's common. I just don't know what it is. >> Or bits. >> Yeah. Okay. So, that's probably fine Good.

All right. So, I think I'm going to have to wrap it up here for today. Um, thanks everybody for coming out. I will see you all uh during my next office hours. Take care. >> Thank you, Sam. Thank you everyone for joining. >> Hallelujah.

>> Jesus Christ. Heat. [music] Heat up here.

>> Heat.