EIP Editing Office Hour #10

Transcript

all right I think we are about time Sam if you would like to um yeah start yes I think um panda is pretty strict about not having um build files in here so I package.json and hard hat config you'll probably have to remove for him to approve it but um yeah Yeah we actually have it in both previous ones as well as we saw it's included in multiple others so that's why we kept it okay um you'll just have to talk to Panda about it then

um yeah generally we like seeing the reference implementation be as small as possible so like if you're pulling in a whole bunch of other packages and stuff we'd like it to be simplified a little bit but like yeah it's not actually a strict rule that you have to remove them so yeah just talk to Panda pip and I'm sure you can agree on something okay so you mentioned you have a question for another EIP has that been resolved or you would like to take it oh yeah it was just uh about uh 6059 so about the reviewer but I think that that

we resolved that already sounds good thank you uh so some I think I have been approached by a couple of other authors but while they are joining we can go by the list that we have here for uh looking into today all right okay so let's take a look at 4834 okay um okay 48 34 that's all good because I

was wondering like should I move 11 55 request like the pull request number five seven one seven two the EAP meeting call it looks like it is for a already final proposal yeah if um foreign doesn't come by and approve this like I reached it on Twitter to him um then yeah we'll have to talk about it as editors but it is a pretty small change so sounds good yeah keep that one open there all right this is Panda pep EIP so we're just going to make sure that

all of the um required sections are filled in here okay good good yeah so this seems fine all right so what do we got here this is moving into last call good

[Music] let's give this a read tree treble tree 712 okay Patricia publish the Phoenix values that screw the domain this News application is to retrieve the subscription and generate appropriate demand separators in a general way and let's integrate each control signatures securely scale up keep fishing and separator all right

so you have to define a function okay that's not present the face unspecified all right so this seems decently well written don't really notice anything so you guys

Okay so rational section is kind of it's okay let's try to achieve this location it's cool I think this is Perfect all right moving on to the next one um some we are joined by another author and the pull request number is 5851 -5851 welcome by the way

hello all right so I've looked at this one already so it's merged so why isn't this merging fail now is this just is this waiting on author approval or are you an author yeah so I think it's just waiting on approval from one of these two um so I actually didn't even find where to approve because it seems to need the Esports to give them

[Music] now this is a new EIP why isn't this merging Panda pip app proved it so yeah looks like it was supposed to be Auto merged but uh for some reason it is not Auto merging yeah let me it's weird five eight five one yeah so it hasn't no is it Heaven merging to draft yeah it

doesn't exist in in master right like so at the very end there's like a notification about waiting report [Music] yeah yeah it's this is a bot problem um I will take a look at this um it I think it might just be because you're the one making the pr and you aren't listed as an author in the EIP [Music] that that's probably the problem but I don't know for sure so I think the author has created an

issue on eipip GitHub repository mentioning the same issue that it needs to be Auto merged and it is not so yeah well like I said I think it's just because the author list here doesn't include the user who created the pr all right yeah yeah and Truth is like our Engineers before and it need to be the right person to post a full request one of the author to do the pr yeah one of the authors needs to make the pr Okay so probably two option either one of the authors who are listed here or you being

added as a author or making the appear okay that's good yeah I think I'm pretty sure that'll be the problem so um if it still doesn't work just give me a ping on Discord or whatever and I'll I'll take a look at it but that should be the problem okay let's see I think we're managed your phone outside okay okay foreign see your draft

so it's just so 5793 is the next proposal to move it to review status if you want to oh okay yeah yeah other way around it's fine there we go now are they tied together here so four nine three eight yeah so they have like a circular dependency thing going on here that's annoying all right let's check these by hand then so 24 64.

so your finals that's good 24.81 481. you are final even better and then four nine three eight four nine three eight is draft okay so then 4938 is there APR for this one foreign get closed

um ah okay so 4938 is still in draft so this one can't be advanced so we have got three proposals here five seven nine three four nine three eight and four eight four four is independent yeah okay and I don't see any PR for four nine three eight to move into

review status so first we have to work on that yeah exactly okay foreign all right

okay so that's the easy one five nine two zero what have we got going on hey it's interesting oh God what's the problem with this one I hadn't reviewed this one before okay oh it's this one okay yeah I think that's fine two zero

are we skipping um six two two zero I yeah I think you mentioned that uh there are some instructions by Panda peep that needs to be ahead of course okay perfect 1753 what's going on here yes this was just they probably haven't fixed the uh yeah they just haven't fixed these so this is just gonna sit here until they fix them okay 73 there's one two two one search system formatting problems that

are wrong with this one I assume looks like there are some changes after lifelines comment okay so I think there's still just a few formatting type issues so if we take all the right description we flip this it goes description of an author

okay then that one doesn't matter that one doesn't matter this one does so security considerations and then after test cases it goes here cool so that is pretty much all that

needs to be done on that one okay Alias okay so those two I've looked at before I think they're doing okay um yeah I think he Incorporated all the changes that you have yeah registered I think this one was fine she would still check um all right

and 61.89 I guess this one needs to rerun now but okay now foreign

so what is this one I don't remember this one this is this is very new okay so why didn't this merge looks like it received some recent comments um foreign

yep six two six nine okay awesome uh the author of five eight five one uh it's been approved by the author but it looks like it's still not matching link is in the chat yeah yeah so why didn't this merge your mic is pretty quiet John can you please repeat if you were

saying something uh yeah actually I would try to uh okay yes there is an approval from this should have worked so so you just give that proof give the proof oh it was like six okay six minutes ago oh okay so

you're adding a file in Eep three four seven five is that is that true yeah so this this file here isn't part of your EIP so you can't add it it has to be in your um assets directory not in uh in the other one um three four seven five yeah Okay so [Music] when we have the three plus mp5s we cannot so yeah you you can't edit uh 3475's files

in in this PR you'll have to do it in a separate one [Music] yeah that's all that's blocking this one that's a very good cache 3475 is already a final proposal so yeah you may have to make a new pull request to make any changes in that proposal is this actually like a problem with

3475 or is this in like an unintentional change yeah any of the authors yeah thank you looks like there is a microphone issue you is trying to connect it so do you think we just need to delete this uh 3475 filters totally um yeah if you just don't change it in your PR it'll be fine

so do you think we should delete the yes uh yeah if you delete the files it'll still count as a change you just have to not change them so they put them back to what they were originally okay so we deleted the new yes result yeah 62475 from the uh from the pr and delete it uh something like this um let's see there's already an update here

is supposed to delete it already okay oh no file refresh yeah so that that looks like it just deleted the pr that like it looks like you deleted the oh okay I got another one here yeah Jesus 2475 uh file in the new PR it'll be something like this so um yeah

so uh that that's how you can get the file back to the original um state in fact again so you think the problems come from the the changes on eip3475 yeah yeah definitely so basically if we can manage to remove this from the new PR then to let me know it's supposed to emerging automatically yeah it's well it should merge um yeah I figured out of it would change it back

to the previous version um yeah I'll probably need to reapprove it because I think it removes approvals whenever you change it um but otherwise it should work okay and I think the last boyfriend oh yeah so now now the file is deleted so that won't work either you need to put it back to the way it was um what should I imagine to do that so maybe I could cut the previous version yeah so if you hear um I can give you the commands just give me one second here maybe I can find the working already in the VIP and the cowardice with uh

so uh this one and then 24.75 okay so something like that and then

and then yeah so it should look something like that I can't guarantee that that's you know exactly correct but those are the commands you should should need roughly to get back to uh to where you were okay so uh I think I will copy and paste on the refund if they have right now give him some sec I will put here right away I will update the pr uh requests I think this particular catch gives a

very good message to all new EIP authors that do not try to put changes of two eips in one PR yeah keep them separate yeah it makes them so much more difficult foreign okay and I will send again up here sounds good you if the issue is not resolved today

um you don't have to wait for another two weeks to get it resolved you are welcome to mention that in Canada's Discord EIP editors Channel okay yeah that should be taken care from them right I'm doing another PR see so if you do another appear the number if you change or the same oh in that case if you are if you can maybe close the original PR and create a new PR that is one way of doing it and you can refer back like that should not be a problem you can retain your old EIP number because that was valid with the

earlier one yeah it'll be totally fine if you need to make a new PR or something that's that's fine okay okay so I'll be working on that one so the idea is uh which is set back the c475 as it was to be and maybe uh do a new PR if we can change the opr set it back to uh what it was to be sure yeah the show okay so I I will try to first uh get it back otherwise I will close this one and do

another VR yeah perfect and just make sure you mention um like the old PR and the new one just so we we remember where we were okay thank you I'm working on that okay thank you thank you okay verify signatures for the signing entity is okay foreign okay so see you I will add a Tui later once it's finished perfect yeah thank you

oh good day see ya all right let's return foreign it's not a useful thing to say this token Center is exploded into tremendous okay

it's represent artworks um cases foreign

okay okay Okay so foreign foreign

foreign okay 60 77. let's take a peek at this one yeah but they both got very good yeah yeah discussion here so why

so we're missing an ew that position signature paste okay yeah so I think we just need to put there yeah that is my

you know professional opinion about what this EV should do UH 60 77 57 48 okay approval expiration I remember reading another one of these um it looks like this is an old one it's just that they have made some changes as per your request yeah perfect so so yeah so I guess the only thing we need to do is figure out what this approve is has nothing changed no

all right uh move status to draft so for this one I'm not clear what we are trying to achieve here here just for some background 1474 was like allowed to go into a start and starter for some changes in the EIP process and because this was interface EAP they wanted to have it maintained somewhere else okay okay okay

I'm not sure if he uh is a new Champion trying to bring it back in action is this just a list of all of the yeah okay so I think foreign we were joined by the author long ago in

eibap meeting and there we discussed that it should be maintained this life should be maintained somewhere else yeah yeah let's find them yeah foreign that the author is not present on the

call but he left a comment on the agenda that he would like his VIP to read I mean this proposal to be reviewed yeah I'll take a quick look at it here do I have any like significant stuff here I don't think so specification foreign so nothing terrible about this one so let's see what we got here so go ahead of an entertainment extension 721 of the management role okay that sounds pretty good um

do we allow just a plain name is that uh yeah we do weird I don't think I've ever seen somebody use just the plane the plain name version right I mean at least we should have something to reach them back right the ID or the email yeah I mean it's allowed so I don't see a problem with it it's just it's it's really who we I guess it's just to give them credit maybe yeah I remember uh the criteria

was we should have at least one email address and one GitHub so because here we have more than one authors yeah exactly okay I'm getting a phone call so I think I'm gonna have to end today's uh call a little bit early sorry about that but uh not a problem yeah um yeah take care I'll talk to you all tomorrow and then probably in two weeks see you yeah thank you sir thank you for joining have a good one bye-bye thanks Victor see you tomorrow